Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XML] Update Time Synchronization Cluster XML to match updated spec #25001

Closed
ReneJosefsen opened this issue Feb 11, 2023 · 3 comments · Fixed by #25037
Closed

[XML] Update Time Synchronization Cluster XML to match updated spec #25001

ReneJosefsen opened this issue Feb 11, 2023 · 3 comments · Fixed by #25037
Labels
Spec XML align SDK XML does not match the spec (including naming, etc)

Comments

@ReneJosefsen
Copy link
Contributor

ReneJosefsen commented Feb 11, 2023 •
edited
Loading

The data types names has been updated in Time Synchronization Cluster and must be updated in the XML as well.

Updated
TimeZoneType -> TimeZoneStruct
DstOffsetType -> DSTOffsetStruct

DstOffset -> DSTOffset (Attribute)

DstTableEmpty -> DSTTableEmpty (Event)
DstStatus -> DSTStatus (Event)

Spec PR: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6212 (already merged)
@ReneJosefsen ReneJosefsen changed the title [XML] Update Time Format Localization Cluster XML to match updated spec [XML] Update Time Synchronization Cluster XML to match updated spec Feb 11, 2023
@bzbarsky-apple bzbarsky-apple added the Spec XML align SDK XML does not match the spec (including naming, etc) label Feb 13, 2023
@bzbarsky-apple
Copy link
Contributor

Change missing from the above list: the DstOffset attribute got renamed to DSTOffset.

@bzbarsky-apple
Copy link
Contributor

And some of the events got renamed, but the SDK does not contain those so far anyway.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 14, 2023
@bzbarsky-apple
Align naming in Time Synchronization Cluster XML with the spec.
ff51ac4 
More spec changes happened in CHIP-Specifications/connectedhomeip-spec#6212

Fixes project-chip#25001
@bzbarsky-apple bzbarsky-apple mentioned this issue Feb 14, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 14, 2023
@bzbarsky-apple
Align naming in Time Synchronization Cluster XML with the spec.
8276ca4 
More spec changes happened in CHIP-Specifications/connectedhomeip-spec#6212

Fixes project-chip#25001
@ReneJosefsen
Copy link
Contributor Author

You are right, I was so focused on the data types that I completely forgot the impact of the Dst to DST change. I have updated the description.

woody-apple pushed a commit that referenced this issue Feb 14, 2023
@bzbarsky-apple
Align naming in Time Synchronization Cluster XML with the spec. (#25037)
99be908 
* Align naming in Time Synchronization Cluster XML with the spec.

More spec changes happened in CHIP-Specifications/connectedhomeip-spec#6212

Fixes #25001

* Regenerate generated code.
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this issue Mar 15, 2023
@bzbarsky-apple @kkasperczyk-no
Align naming in Time Synchronization Cluster XML with the spec. (#25037)
84616a9 
* Align naming in Time Synchronization Cluster XML with the spec.

More spec changes happened in CHIP-Specifications/connectedhomeip-spec#6212

Fixes project-chip/connectedhomeip#25001

* Regenerate generated code.
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this issue Mar 15, 2023
@bzbarsky-apple @kkasperczyk-no
Align naming in Time Synchronization Cluster XML with the spec. (#25037)
39c8945 
* Align naming in Time Synchronization Cluster XML with the spec.

More spec changes happened in CHIP-Specifications/connectedhomeip-spec#6212

Fixes project-chip/connectedhomeip#25001

* Regenerate generated code.
lecndav pushed a commit to lecndav/connectedhomeip that referenced this issue Mar 22, 2023
@bzbarsky-apple
Align naming in Time Synchronization Cluster XML with the spec. (proj…
abc059f 
…ect-chip#25037)

* Align naming in Time Synchronization Cluster XML with the spec.

More spec changes happened in CHIP-Specifications/connectedhomeip-spec#6212

Fixes project-chip#25001

* Regenerate generated code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Spec XML align SDK XML does not match the spec (including naming, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align naming in Time Synchronization Cluster XML with the spec. bzbarsky-apple/connectedhomeip
2 participants
@bzbarsky-apple @ReneJosefsen