Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Platform] Darwin openCommissioningWindowWithSetupPasscode should perhaps allow nil passcode #22842

Closed
bzbarsky-apple opened this issue Sep 23, 2022 · 1 comment · Fixed by #26037
Closed

[Platform] Darwin openCommissioningWindowWithSetupPasscode should perhaps allow nil passcode #22842

bzbarsky-apple opened this issue Sep 23, 2022 · 1 comment · Fixed by #26037
Assignees
@bzbarsky-apple
Labels
darwin p2 priority 2 work v1.1

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Sep 23, 2022 •
edited
Loading

Reproduction steps

Or not passing a passcode at all (and name that version openCommissioningWindowWithDiscriminator:....)?

In either case, the underlying impl would use a randomly generated passcode.

Platform

darwin

Platform Version(s)

No response

Type

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 23, 2022
Merged
@stale
Copy link

stale bot commented Mar 22, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Mar 22, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Mar 23, 2023
@woody-apple woody-apple added the p2 priority 2 work label Apr 4, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Apr 10, 2023
@bzbarsky-apple
Add API on Darwin to open commissioning windows without explicitly pr…
368b76f 
…oviding a setup code.

Fixes project-chip#22842
@bzbarsky-apple bzbarsky-apple mentioned this issue Apr 10, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Apr 10, 2023
@bzbarsky-apple
Add API on Darwin to open commissioning windows without explicitly pr…
b49cb5f 
…oviding a setup code.

Fixes project-chip#22842
bzbarsky-apple added a commit that referenced this issue Apr 11, 2023
@bzbarsky-apple
Add API on Darwin to open commissioning windows without explicitly pr…
ed5ebd2 
…oviding a setup code. (#26037)

Fixes #22842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
darwin p2 priority 2 work v1.1
Projects
None yet
Milestone
No milestone
2 participants
@woody-apple @bzbarsky-apple