cmd_ping/cmd_send in Shell are obsolete #19889
Labels
Comments
tcarmelveilleux
added a commit
to tcarmelveilleux/connectedhomeip
that referenced
this issue
Jun 26, 2022
- Both cmd_send and cmd_ping used pre-spec internal test-level APIs which have grown stale and no longer function. They showed API usage that was both incorrect and dangerous. They are were also no longer used. Fixes project-chip#19889 Fixes project-chip#6293 This PR removes these stale commands, which already had become empty in a prior PR since the way they used FabricTable was also incorrect (and this had been corrected at the time). Testing done: - Unit tests still pass - Integration tests still pass
Damian-Nordic
pushed a commit
that referenced
this issue
Jun 27, 2022
* Remove shell cmd_ping/cmd_send that were obsolete - Both cmd_send and cmd_ping used pre-spec internal test-level APIs which have grown stale and no longer function. They showed API usage that was both incorrect and dangerous. They are were also no longer used. Fixes #19889 Fixes #6293 This PR removes these stale commands, which already had become empty in a prior PR since the way they used FabricTable was also incorrect (and this had been corrected at the time). Testing done: - Unit tests still pass - Integration tests still pass * Remove more unused commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Shell's
examples/shell/shell_common/cmd_ping.cppandexamples/shell/shell_common/cmd_send.cppwere doing non-Matter low-level communication used early in bring-up, but pretending to use modern APIs, as the code was "kept building" the whole time.These commands need to be removed outright.
Proposed Solution
The text was updated successfully, but these errors were encountered: