Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor VerifyAttestationInformation argument list into a struct #14758

Closed
cecille opened this issue Feb 3, 2022 · 0 comments · Fixed by #15090
Closed

Refactor VerifyAttestationInformation argument list into a struct #14758

cecille opened this issue Feb 3, 2022 · 0 comments · Fixed by #15090
Labels
V1.X

Comments

@cecille
Copy link
Contributor

cecille commented Feb 3, 2022

Problem

There are lots of arguments. A struct is nicer visually and if we need to add more arguments down the line it's easier.

Proposed Solution

individual args -> struct.
@cecille cecille mentioned this issue Feb 3, 2022
Merged
cecille added a commit to cecille/connectedhomeip that referenced this issue Feb 11, 2022
@cecille
Consolidate dac verification parameters into struct.
3544e69 
Per request in project-chip#14845, issue project-chip#14758
@cecille cecille mentioned this issue Feb 11, 2022
Merged
bzbarsky-apple pushed a commit that referenced this issue Feb 17, 2022
@cecille
Consolidate dac verification parameters into struct. (#15090)
b541dee 
* Consolidate dac verification parameters into struct.

Per request in #14845, issue #14758

* make struct not use references.

* Fix up some naming.
jamesluo11 pushed a commit to jamesluo11/connectedhomeip that referenced this issue Apr 26, 2022
@cecille @fuxingguo16
Consolidate dac verification parameters into struct. (project-chip#15090
abebb45 
)

* Consolidate dac verification parameters into struct.

Per request in project-chip#14845, issue project-chip#14758

* make struct not use references.

* Fix up some naming.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
V1.X
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consolidate dac verification parameters into struct. cecille/connectedhomeip
2 participants
@cecille @woody-apple