Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR 14227 broke door lock physical security #14573

Closed
bzbarsky-apple opened this issue Jan 29, 2022 · 0 comments · Fixed by #14582
Closed

PR 14227 broke door lock physical security #14573

bzbarsky-apple opened this issue Jan 29, 2022 · 0 comments · Fixed by #14582
Assignees
@erjiaqing
Labels
Interaction Model Work spec Mismatch between spec and implementation

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

db640e8 (added after reviews, with no review on it, and reverting security-critical fixes from another PR) breaks door lock physical security by hiding open/close events from other fabrics.

Proposed Solution

  1. Don't do that. Restore the bit in cluster-objects.zapt, remove the handling of "nullable fabric index" as indicating fabric-scoping in EventLogging.h.
  2. Make sure significant functionality changes to PRs get reviewed, not snuck in after reviews.
@bzbarsky-apple bzbarsky-apple added spec Mismatch between spec and implementation critical security issue labels Jan 29, 2022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jan 29, 2022
@bzbarsky-apple
Stop incorrectly flagging door lock events as fabric-scoped.
4775a04 
Fixes project-chip#14365
Fixes project-chip#14573
@bzbarsky-apple bzbarsky-apple mentioned this issue Jan 29, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jan 29, 2022
@bzbarsky-apple
Stop incorrectly flagging door lock events as fabric-scoped.
5dcc16a 
Fixes project-chip#14365
Fixes project-chip#14573
andy31415 pushed a commit that referenced this issue Jan 30, 2022
@bzbarsky-apple
Stop incorrectly flagging door lock events as fabric-scoped. (#14582)
359fd43 
Fixes #14365
Fixes #14573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erjiaqing erjiaqing

Labels
Interaction Model Work spec Mismatch between spec and implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop incorrectly flagging door lock events as fabric-scoped. bzbarsky-apple/connectedhomeip
2 participants
@erjiaqing @bzbarsky-apple