Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this wastes one copy of the data and that could be optimized away #12512

Closed
todo bot opened this issue Dec 2, 2021 · 0 comments
Closed

this wastes one copy of the data and that could be optimized away #12512

todo bot opened this issue Dec 2, 2021 · 0 comments
Assignees
Labels

Comments

@todo
Copy link

todo bot commented Dec 2, 2021

/// TODO: this wastes one copy of the data and that could be optimized away
if (info->mAddressType == chip::Inet::IPAddressType::kIPv6)
{
err = udp->SendTo(mIpv6BroadcastAddress, port, data.CloneData(), udp->GetBoundInterface());
}
#if INET_CONFIG_ENABLE_IPV4
else if (info->mAddressType == chip::Inet::IPAddressType::kIPv4)
{
err = udp->SendTo(mIpv4BroadcastAddress, port, data.CloneData(), udp->GetBoundInterface());
}
#endif


This issue was generated by todo based on a TODO comment in 9cb6acd when #12417 was merged. cc @kghost.
@todo todo bot added the todo label Dec 2, 2021
@todo todo bot assigned kghost Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants