Skip to content

Commit

Permalink
Hoist "writing" log up in processing, to preserve similar functionality
Browse files Browse the repository at this point in the history
  • Loading branch information
andreilitvin committed Jan 30, 2025
1 parent 3090732 commit d36e731
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 3 additions & 0 deletions src/app/WriteHandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -834,6 +834,9 @@ CHIP_ERROR WriteHandler::WriteClusterData(const Access::SubjectDescriptor & aSub
// the write is done via the DataModel interface
VerifyOrReturnError(mDataModelProvider != nullptr, CHIP_ERROR_INCORRECT_STATE);

ChipLogDetail(DataManagement, "Writing attribute: Cluster=" ChipLogFormatMEI " Endpoint=0x%x AttributeId=" ChipLogFormatMEI,
ChipLogValueMEI(aPath.mClusterId), aPath.mEndpointId, ChipLogValueMEI(aPath.mAttributeId));

DataModel::ActionReturnStatus status = CheckWriteAllowed(aSubject, aPath);
if (status.IsSuccess())
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,6 @@ std::optional<CHIP_ERROR> TryWriteViaAccessInterface(const ConcreteDataAttribute
DataModel::ActionReturnStatus CodegenDataModelProvider::WriteAttribute(const DataModel::WriteAttributeRequest & request,
AttributeValueDecoder & decoder)
{
ChipLogDetail(DataManagement, "Writing attribute: Cluster=" ChipLogFormatMEI " Endpoint=0x%x AttributeId=" ChipLogFormatMEI,
ChipLogValueMEI(request.path.mClusterId), request.path.mEndpointId, ChipLogValueMEI(request.path.mAttributeId));

auto metadata = Ember::FindAttributeMetadata(request.path);

// Explicit failure in finding a suitable metadata
Expand Down

0 comments on commit d36e731

Please sign in to comment.