Add some rules to IWYU mapping files and fix logging in iwyu_check.py…

… script
project-chip · Nov 18, 2022 · c086c2b · c086c2b
1 parent 5b2bdd8
commit c086c2b
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 18 deletions.
diff --git a/scripts/helpers/iwyu_check.py b/scripts/helpers/iwyu_check.py
@@ -156,7 +156,7 @@ def main(compile_commands_glob, scanning_destination, mapping_file_dir, iwyu_arg
             clang_args
         ]
 
-        logging.info("Start scanning include using IWYU for %s platform" % platform)
+        logging.info("Start scanning include using IWYU for %s platform", platform)
         status = subprocess.Popen(" ".join(command_arr),
                                   shell=True,
                                   text=True,
@@ -170,13 +170,13 @@ def main(compile_commands_glob, scanning_destination, mapping_file_dir, iwyu_arg
             line = status.stdout.readline().rstrip()
 
             if re.match(r"^.*([A-Za-z0-9]+(/[A-Za-z0-9]+)+)\.cpp should [a-zA-Z]+ these lines:$", line):
-                logging.warning("\n"+line)
+                logging.warning("\n%s", line)
 
             elif re.match(r"^.*([A-Za-z0-9]+(/[A-Za-z0-9]+)+)\.[a-zA-Z]+ has correct #includes/fwd-decls\)$", line):
-                logging.info("\n"+line)
+                logging.info("\n%s", line)
 
             elif re.match(r"^The full include-list for .*$", line):
-                logging.warning("\n"+line)
+                logging.warning("\n%s", line)
                 warning_in_files += 1
 
             else:

diff --git a/scripts/helpers/platforms/Linux/iwyu.imp b/scripts/helpers/platforms/Linux/iwyu.imp
@@ -1,5 +1,3 @@
 [
     { ref: "../iwyu.imp" },
-    { include: [ '"platform/Linux/CHIPDevicePlatformConfig.h"', "private", '<platform/CHIPDeviceConfig.h>', "public" ] },
-    { include: [ '"platform/Linux/SystemPlatformConfig.h"', "private", '<system/SystemConfig.h>', "public" ] },
 ]
diff --git a/scripts/helpers/platforms/Tizen/iwyu.imp b/scripts/helpers/platforms/Tizen/iwyu.imp
@@ -1,18 +1,6 @@
 [
     { ref: "../iwyu.imp" },
 
-    { include: [ '"platform/Tizen/CHIPDevicePlatformConfig.h"', "private", '<platform/CHIPDeviceConfig.h>', "public" ] },
-    { include: [ '"platform/Tizen/SystemPlatformConfig.h"', "private", '<system/SystemConfig.h>', "public" ] },
-
-    ## Do not include some Impl headers directly
-    { include: [ '"platform/Tizen/BLEManagerImpl.h"', "private", '<platform/internal/BLEManager.h>', "public" ] },
-    { include: [ '"platform/Tizen/ConnectivityManagerImpl.h"', "private", '<platform/ConnectivityManager.h>', "public" ] },
-    { include: [ '"platform/Tizen/PlatformManagerImpl.h"', "private", '<platform/PlatformManager.h>', "public" ] },
-    { include: [ '"platform/Tizen/KeyValueStoreManagerImpl.h"', "private", '<platform/KeyValueStoreManager.h>', "public" ] },
-    { include: [ '<platform/Tizen/ThreadStackManagerImpl.h>', "private", '<platform/ThreadStackManager.h>', "public" ] },
-
-    { include: [ '<platform/Tizen/DeviceInstanceInfoProviderImpl.h>', "private", '"platform/Tizen/DeviceInstanceInfoProviderImpl.h"', "public" ] },
-
     { include: [ '<thread-type.h>', "private", '<thread.h>', "public" ] },
     { include: [ '<tizen_error.h>', "private", '<tizen.h>', "public" ] },
 

diff --git a/scripts/helpers/platforms/iwyu.imp b/scripts/helpers/platforms/iwyu.imp
@@ -78,4 +78,15 @@
     { symbol: [ 'tm', private, '<sys/time.h>', public ] },
     { symbol: [ 'declval', 'private', '<utility>', 'public' ] },
 
+    ## Do not include some Impl headers directly
+    { include: [ '@"platform/.*/BLEManagerImpl.h"', "private", '<platform/internal/BLEManager.h>', "public" ] },
+    { include: [ '@"platform/.*/ConnectivityManagerImpl.h"', "private", '<platform/ConnectivityManager.h>', "public" ] },
+    { include: [ '@"platform/.*/PlatformManagerImpl.h"', "private", '<platform/PlatformManager.h>', "public" ] },
+    { include: [ '@"platform/.*/KeyValueStoreManagerImpl.h"', "private", '<platform/KeyValueStoreManager.h>', "public" ] },
+    { include: [ '@<platform/.*/ThreadStackManagerImpl.h>', "private", '<platform/ThreadStackManager.h>', "public" ] },
+
+    ## Config
+    { include: [ '@"platform/.*/CHIPDevicePlatformConfig.h"', "private", '<platform/CHIPDeviceConfig.h>', "public" ] },
+    { include: [ '@"platform/.*/SystemPlatformConfig.h"', "private", '<system/SystemConfig.h>', "public" ] },
+
 ]