Skip to content

Commit

Permalink
Fix codegen to handle the int sizes between int32 and int64 correctly. (
Browse files Browse the repository at this point in the history
#10750)

Also fixes handling of eui64, not that we should be using that to
start with.

Does not enable Accessors bits for these, though, because it's not
clear how they would be stored in the attribute store.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Oct 25, 2021
1 parent 5b6d467 commit b673c18
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
8 changes: 7 additions & 1 deletion src/app/zap-templates/common/override.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,14 @@ function atomicType(arg)
switch (arg.name) {
case 'boolean':
return 'bool';
case 'int40s':
case 'int48s':
case 'int56s':
case 'int64s':
return 'int64_t';
case 'int40u':
case 'int48u':
case 'int56u':
case 'int64u':
case 'bitmap64':
return 'uint64_t';
Expand Down Expand Up @@ -57,7 +63,7 @@ function atomicType(arg)
case 'long_char_string':
return 'chip::CharSpan';
case 'eui64':
return 'chip::node_id';
return 'chip::NodeId';
case 'percent':
return 'chip::Percent';
case 'percent100ths':
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b673c18

Please sign in to comment.