Skip to content

Commit

Permalink
Have scripts/tools/memory use pyelftools by default. (#6974)
Browse files Browse the repository at this point in the history
#### Problem

Scripts under scripts/tools/memory can collect information from images
in different ways. The default has been to use `readelf` because it's
fastest. However, `readelf` is not availably by default on Mac OS.

#### Summary of Changes

Use `elftools` as the default collection method. (The previous default
method, `readelf`, can be used by giving a `--collect-method readelf`
option.)

#### Testing

Ran each scripts in `scripts/tools/memory/*.py` in an environment with
no working `readelf`.
  • Loading branch information
kpschoedel authored May 20, 2021
1 parent e6d7343 commit 9ebcdc3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/tools/memory/memdf/collect.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
'help': 'Method of input processing',
'metavar': 'METHOD',
'choices': ['elftools', 'readelf', 'bloaty', 'csv', 'tsv', 'su'],
'default': 'readelf',
'default': 'elftools',
'argparse': {
'alias': ['-f'],
},
Expand Down

0 comments on commit 9ebcdc3

Please sign in to comment.