Skip to content

Commit

Permalink
Apply documentation suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
  • Loading branch information
hicklin and bzbarsky-apple authored Jul 25, 2023
1 parent 885d240 commit 9095d32
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion examples/all-clusters-app/linux/main-common.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ void ApplicationInit()

void ApplicationShutdown()
{
// These have been initialised via the emberAfXxxClusterInitCallback methods. We need to destroy them before shutdown.
// These may have been initialised via the emberAfXxxClusterInitCallback methods. We need to destroy them before shutdown.
Clusters::DishwasherMode::Shutdown();
Clusters::LaundryWasherMode::Shutdown();
Clusters::RvcCleanMode::Shutdown();
Expand Down
4 changes: 3 additions & 1 deletion src/app/clusters/mode-base-server/mode-base-server.h
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,9 @@ class Delegate
// todo change once there is a clear public interface for the OnOff cluster data dependencies (#27508)
static IntrusiveList<Instance> gModeBaseAliasesInstances;

// This does not return a const of gModeBaseAliasesInstances since the caller might need to call the element's UpdateXxx methods.
// This does not return a refernce to const IntrusiveList, because the caller might need
// to change the state of the instances in the list and const IntrusiveList only allows
// access to const Instance.
IntrusiveList<Instance> & GetModeBaseInstanceList();

} // namespace ModeBase
Expand Down

0 comments on commit 9095d32

Please sign in to comment.