Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
  • Loading branch information
nivi-apple and bzbarsky-apple authored Jul 26, 2023
1 parent 7bfa759 commit 7b0435a
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions src/darwin/Framework/CHIPTests/MTROTAProviderTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -950,7 +950,7 @@ - (void)test006_DoBDXTransferWithTwoOTARequesters
NSString * otaRawImagePath1 = @"/tmp/ota-raw-image-v10";
NSString * otaRawImagePath2 = @"/tmp/ota-raw-image-v5";

// Check if the ota raw image exists at kOtaRawImagePath1 and kOtaRawImagePath2
// Check whether the ota raw image exists at otaRawImagePath1 and otaRawImagePath2
XCTAssertTrue([[NSFileManager defaultManager] fileExistsAtPath:otaRawImagePath1]);
XCTAssertTrue([[NSFileManager defaultManager] fileExistsAtPath:otaRawImagePath2]);

Expand Down Expand Up @@ -1315,12 +1315,10 @@ - (void)test007_DoBDXTransferIncrementalOtaUpdate
NSString * otaRawImagePath1 = @"/tmp/ota-raw-image-v5";
NSString * otaRawImagePath2 = @"/tmp/ota-raw-image-v10";

// Check if the ota raw image exists at kOtaRawImagePath1 and kOtaRawImagePath2
// Check whether the ota raw image exists at otaRawImagePath1 and otaRawImagePath2
XCTAssertTrue([[NSFileManager defaultManager] fileExistsAtPath:otaRawImagePath1]);
XCTAssertTrue([[NSFileManager defaultManager] fileExistsAtPath:otaRawImagePath2]);

// Test that if we advertise ourselves as a provider we end up getting a
// QueryImage callbacks that we can respond to.
__auto_type * device = sConnectedDevice3;

__auto_type * checker =
Expand Down

0 comments on commit 7b0435a

Please sign in to comment.