Skip to content

Commit

Permalink
Update one more ifdef surround: if no extra logging, remove a larger …
Browse files Browse the repository at this point in the history
…code chunk
  • Loading branch information
andreilitvin committed Nov 8, 2024
1 parent c65bed5 commit 63e2099
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/app/reporting/Engine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -109,16 +109,16 @@ DataModel::ActionReturnStatus RetrieveClusterData(DataModel::Provider * dataMode
*encoderState = attributeValueEncoder.GetState();
}

#if CHIP_CONFIG_DATA_MODEL_EXTRA_LOGGING
// Out of space errors may be chunked data, reporting those cases would be very confusing
// as they are not fully errors. Report only others (which presumably are not recoverable
// and will be sent to the client as well).
if (!status.IsOutOfSpaceEncodingResponse())
{
DataModel::ActionReturnStatus::StringStorage storage;
#if CHIP_CONFIG_DATA_MODEL_EXTRA_LOGGING
ChipLogError(DataManagement, "Failed to read attribute: %s", status.c_str(storage));
#endif
}
#endif
return status;
}

Expand Down

0 comments on commit 63e2099

Please sign in to comment.