Skip to content

Commit

Permalink
Fixes issue: #29182, #29183
Browse files Browse the repository at this point in the history
  • Loading branch information
manjunath-grl committed Sep 13, 2023
1 parent 3623baf commit 5752dc4
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 20 deletions.
2 changes: 1 addition & 1 deletion scripts/tests/chiptest/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ def target_for_name(name: str):
return TestTarget.LOCK
if name.startswith("OTA_"):
return TestTarget.OTA
if name.startswith("Test_TC_BRBINFO_"):
if name.startswith("Test_TC_BRBINFO_") or name.startswith("Test_TC_ACT_"):
return TestTarget.BRIDGE
return TestTarget.ALL_CLUSTERS

Expand Down
1 change: 1 addition & 0 deletions src/app/tests/suites/certification/Test_TC_ACL_2_5.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ tests:
PICS: ACL.S.E01
command: "readEvent"
event: "AccessControlExtensionChanged"
eventNumber: "LastReceivedEventNumber + 1"
response:
value:
{
Expand Down
1 change: 1 addition & 0 deletions src/app/tests/suites/certification/Test_TC_ACL_2_6.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ tests:
PICS: ACL.S.E00
command: "readEvent"
event: "AccessControlEntryChanged"
eventNumber: "LastReceivedEventNumber + 1"
response:
value:
{
Expand Down
5 changes: 1 addition & 4 deletions src/app/tests/suites/certification/Test_TC_GRPKEY_2_1.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,7 @@ tests:
EpochStartTime2: "18446744073709551614",
}

#Step 5 Removed in test-plan PR: https://github.com/CHIP-Specifications/chip-test-plans/pull/3425
#TH sends AddGroup Command to DUT on PIXIT.G.ENDPOINT with the the following settings GroupID: 0x0103 GroupName: "Test Group"
# Step 5 does not exist in the test plan.

- label:
"Step 6: TH reads GroupTable attribute from GroupKeyManagement cluster
Expand Down Expand Up @@ -185,5 +184,3 @@ tests:
value: MaxGroupKeysPerFabricValue
response:
error: UNSUPPORTED_WRITE
#Step 12 Removed in test-plan PR: https://github.com/CHIP-Specifications/chip-test-plans/pull/3425
#TH cleans up the groups by sending the RemoveAllGroups command to the DUT on PIXIT.G.ENDPOINT
8 changes: 1 addition & 7 deletions src/app/tests/suites/certification/Test_TC_SC_4_1.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# Auto-generated scripts for harness use only, please review before automation. The endpoints and cluster names are currently set to default

name: 22.4.1. [TC-SC-4.1] Commissionable Node Discovery [DUT as Commissionee]

Expand Down Expand Up @@ -1201,11 +1200,6 @@ tests:
- name: "value"
value: deviceType

- label: "Step 10h: Check Commissioning Mode (_CM)"
PICS: MCORE.SC.EXTENDED_DISCOVERY
cluster: "DiscoveryCommands"
command: "FindCommissionableByCommissioningMode"

# TXT Records

- label: "Step 10i: TXT key for discriminator (D)"
Expand Down Expand Up @@ -1275,7 +1269,7 @@ tests:
an unsigned integer with units of milliseconds and shall be encoded as
a variable length decimal number in ASCII, omitting leading zeros.
Shall not exceed 65535."
PICS: MCORE.SC.SAI_OP_DISCOVERY_KEY
PICS: MCORE.SC.SAI_OP_DISCOVERY_KEY && MCORE.SC.EXTENDED_DISCOVERY
cluster: "DiscoveryCommands"
command: "FindCommissionable"
response:
Expand Down
4 changes: 2 additions & 2 deletions src/app/tests/suites/certification/Test_TC_TSTAT_2_1.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ tests:
maxValue: 3000

- label: "Step 17a: Reads attribute from DUT: MinHeatSetpointLimit"
PICS: TSTAT.S.A0015 && TSTAT.S.F05 && TSTAT.S.A0017 && TSTAT.S.A0003
PICS: TSTAT.S.A0015 && TSTAT.S.F05 && TSTAT.S.A0017 && TSTAT.S.A0019
command: "readAttribute"
attribute: "MinHeatSetpointLimit"
response:
Expand All @@ -362,7 +362,7 @@ tests:
verifies that the value is within range"
command: "readAttribute"
attribute: "MinHeatSetpointLimit"
PICS: TSTAT.S.A0003 && !TSTAT.S.A0015 && !TSTAT.S.A0016 && !TSTAT.S.F05
PICS: TSTAT.S.A0015 && !TSTAT.S.A0003 && !TSTAT.S.F05
response:
constraints:
type: int16s
Expand Down
10 changes: 5 additions & 5 deletions src/app/tests/suites/certification/Test_TC_TSTAT_2_2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1577,37 +1577,37 @@ tests:
"Step 10a: Writes (sets back) default value of MinHeatSetpointLimit"
command: "writeAttribute"
attribute: "MinHeatSetpointLimit"
PICS: TSTAT.S.F01 && TSTAT.S.A0015 && TSTAT.S.A0003
PICS: TSTAT.S.F00 && TSTAT.S.A0015 && TSTAT.S.A0003
arguments:
value: AbsMinHeatSetpointLimitValue

- label:
"Step 10a: Writes (sets back) default value of MinHeatSetpointLimit"
command: "writeAttribute"
attribute: "MinHeatSetpointLimit"
PICS: TSTAT.S.F01 && TSTAT.S.A0015 && !TSTAT.S.A0003
PICS: TSTAT.S.F00 && TSTAT.S.A0015 && !TSTAT.S.A0003
arguments:
value: 700

- label: "Step 10a: Writes (sets back)default value of MaxHeatSetpointLimit"
command: "writeAttribute"
attribute: "MaxHeatSetpointLimit"
PICS: TSTAT.S.F01 && TSTAT.S.A0016 && !TSTAT.S.F05 && TSTAT.S.A0004
PICS: TSTAT.S.F00 && TSTAT.S.A0016 && !TSTAT.S.F05 && TSTAT.S.A0004
arguments:
value: AbsMaxHeatSetpointLimitValue

- label: "Step 10a: Writes (sets back)default value of MaxHeatSetpointLimit"
command: "writeAttribute"
attribute: "MaxHeatSetpointLimit"
PICS: TSTAT.S.F01 && TSTAT.S.A0016 && !TSTAT.S.F05 && !TSTAT.S.A0004
PICS: TSTAT.S.F00 && TSTAT.S.A0016 && !TSTAT.S.F05 && !TSTAT.S.A0004
arguments:
value: 3000

- label:
"Step 10a: Writes MaxHeatSetpointLimit That meets the deadband of 2.5C"
command: "writeAttribute"
attribute: "MaxHeatSetpointLimit"
PICS: TSTAT.S.F01 && TSTAT.S.A0016 && TSTAT.S.F05
PICS: TSTAT.S.F00 && TSTAT.S.A0016 && TSTAT.S.F05
arguments:
value: 2950

Expand Down
6 changes: 5 additions & 1 deletion src/app/tests/suites/manualTests.json
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,11 @@
"DoorLock": ["Test_TC_DRLK_2_10", "Test_TC_DRLK_3_2"],
"LocalizationConfiguration": [],
"LevelControl": [],
"LaundryWasherMode": ["Test_TC_LWM_1_2", "Test_TC_LWM_3_2"],
"LaundryWasherMode": [
"Test_TC_LWM_1_2",
"Test_TC_LWM_3_2",
"Test_TC_LWM_3_3"
],
"OnOff": ["Test_TC_OO_2_3"],
"OperationalState": ["Test_TC_OPSTATE_2_2"],
"RelativeHumidityMeasurement": ["Test_TC_RH_2_2"],
Expand Down

0 comments on commit 5752dc4

Please sign in to comment.