Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com>
  • Loading branch information
lpbeliveau-silabs and mkardous-silabs authored Oct 11, 2023
1 parent 1c9f9ce commit 42fc1fc
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/app/clusters/scenes-server/scenes-server.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ CHIP_ERROR ScenesServer::Init()
ChipLogDetail(Zcl, "ERR: getting the scenes FeatureMap on Endpoint %hu Status: %x", endpoint, status);
}

// Forcing matter mandatory features on
// Explicit AttributeValuePairs is mandatory for matter so we force it here
featureMap |= to_underlying(Feature::kExplicit);
status = Attributes::FeatureMap::Set(endpoint, featureMap);
Expand Down Expand Up @@ -212,7 +211,7 @@ void AddSceneParse(CommandHandlerInterface::HandlerContext & ctx, const CommandD

uint8_t EFSCount = 0;

uint32_t featureMap = 0x00;
uint32_t featureMap = 0;
ReturnOnFailure(AddResponseOnError(ctx, response, Attributes::FeatureMap::Get(ctx.mRequestPath.mEndpointId, &featureMap)));

SceneData storageData(CharSpan(), transitionTimeMs);
Expand Down Expand Up @@ -394,7 +393,7 @@ CHIP_ERROR StoreSceneParse(const FabricIndex & fabricIdx, const EndpointId & end
}
else
{
uint32_t featureMap = 0x00;
uint32_t featureMap = 0;
ReturnErrorOnFailure(
StatusIB(ToInteractionModelStatus(Attributes::FeatureMap::Get(endpointID, &featureMap))).ToChipError());
// Check if we still support scenes name in case an OTA changed that, if we don't, set name to empty
Expand Down

0 comments on commit 42fc1fc

Please sign in to comment.