Skip to content

Commit

Permalink
Increase log message sizes on iOS. (#21515)
Browse files Browse the repository at this point in the history
Default to the same 1 MTU in base64 as linux/mac, but also in the
XCode config just set a fairly generous 4KB limit.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Jul 12, 2023
1 parent e18a3e2 commit 362e13b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/darwin/Framework/chip_xcode_build_connector.sh
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ declare -a args=(
'chip_crypto="mbedtls"'
'chip_build_tools=false'
'chip_build_tests=false'
'chip_log_message_max_size=4096' # might as well allow nice long log messages
'chip_disable_platform_kvs=true'
'target_cpu="'"$target_cpu"'"'
'target_defines='"$target_defines"
Expand Down
2 changes: 1 addition & 1 deletion src/lib/core/core.gni
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ declare_args() {
chip_automation_logging = chip_logging

# Configure the maximum size for logged messages
if (current_os == "linux" || current_os == "mac") {
if (current_os == "linux" || current_os == "mac" || current_os == "ios") {
# Allow base64 encoding of 1 MTU (4 * (1280 / 3) + padding
chip_log_message_max_size = 1708
} else {
Expand Down

0 comments on commit 362e13b

Please sign in to comment.