Fixed potential buffer overrun in HwSetVehicleID.

project-chip · Dec 13, 2023 · 234e956 · 234e956
1 parent 5b7f089
commit 234e956
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/examples/all-clusters-app/all-clusters-common/src/EnergyEvseDelegateImpl.cpp b/examples/all-clusters-app/all-clusters-common/src/EnergyEvseDelegateImpl.cpp
@@ -382,7 +382,7 @@ Status EnergyEvseDelegate::HwSetRFID(ByteSpan uid)
  */
 Status EnergyEvseDelegate::HwSetVehicleID(const CharSpan & newValue)
 {
-    if ((mVehicleID.IsNull()) || (strcmp(newValue.data(), mVehicleID.Value().data()) != 0))
+    if (mVehicleID.IsNull() || !newValue.data_equal(mVehicleID.Value()))
     {
         /* create a copy of the string so the callee doesn't have to keep it */
         char * destinationBuffer = new char[kMaxVehicleIDBufSize];
@@ -403,7 +403,7 @@ Status EnergyEvseDelegate::HwSetVehicleID(const CharSpan & newValue)
 
         mVehicleID = MakeNullable(static_cast<CharSpan>(destinationString));
 
-        ChipLogDetail(AppServer, "VehicleID updated to %s", mVehicleID.Value().data());
+        ChipLogDetail(AppServer, "VehicleID updated");
         MatterReportingAttributeChangeCallback(mEndpointId, EnergyEvse::Id, VehicleID::Id);
     }