Address review comments.

project-chip · Sep 14, 2022 · 1307520 · 1307520
1 parent 40677ff
commit 1307520
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 15 deletions.
diff --git a/examples/darwin-framework-tool/commands/tests/TestCommandBridge.h b/examples/darwin-framework-tool/commands/tests/TestCommandBridge.h
@@ -168,7 +168,9 @@ class TestCommandBridge : public CHIPCommandBridge,
         }
 
         mConnectedDevices[identity] = [MTRBaseDevice deviceWithNodeID:@(value.nodeId) controller:controller];
-        NextTest();
+        dispatch_async(mCallbackQueue, ^{
+            NextTest();
+        });
         return CHIP_NO_ERROR;
     }
 

diff --git a/src/darwin/Framework/CHIP/MTRDeviceControllerOverXPC.m b/src/darwin/Framework/CHIP/MTRDeviceControllerOverXPC.m
@@ -123,10 +123,7 @@ - (void)fetchControllerIdWithQueue:(dispatch_queue_t)queue completion:(MTRFetchC
 
 - (MTRBaseDevice *)baseDeviceForNodeID:(NSNumber *)nodeID
 {
-    return [[MTRDeviceOverXPC alloc] initWithControllerID:self.controllerID
-                                               controller:self
-                                                 deviceID:nodeID
-                                            xpcConnection:self.xpcConnection];
+    return [[MTRDeviceOverXPC alloc] initWithControllerOverXPC:self deviceID:nodeID xpcConnection:self.xpcConnection];
 }
 
 - (instancetype)initWithControllerID:(id)controllerID

diff --git a/src/darwin/Framework/CHIP/MTRDeviceOverXPC.h b/src/darwin/Framework/CHIP/MTRDeviceOverXPC.h
@@ -28,10 +28,9 @@ NS_ASSUME_NONNULL_BEGIN
 - (instancetype)init NS_UNAVAILABLE;
 + (instancetype)new NS_UNAVAILABLE;
 
-- (instancetype)initWithControllerID:(id<NSCopying> _Nullable)controllerID
-                          controller:(MTRDeviceControllerOverXPC *)controller
-                            deviceID:(NSNumber *)deviceID
-                       xpcConnection:(MTRDeviceControllerXPCConnection *)xpcConnection;
+- (instancetype)initWithControllerOverXPC:(MTRDeviceControllerOverXPC *)controllerOverXPC
+                                 deviceID:(NSNumber *)deviceID
+                            xpcConnection:(MTRDeviceControllerXPCConnection *)xpcConnection;
 
 @end
 

diff --git a/src/darwin/Framework/CHIP/MTRDeviceOverXPC.m b/src/darwin/Framework/CHIP/MTRDeviceOverXPC.m
@@ -38,13 +38,12 @@ @interface MTRDeviceOverXPC ()
 
 @implementation MTRDeviceOverXPC
 
-- (instancetype)initWithControllerID:(id<NSCopying> _Nullable)controllerID
-                          controller:(MTRDeviceControllerOverXPC *)controller
-                            deviceID:(NSNumber *)deviceID
-                       xpcConnection:(MTRDeviceControllerXPCConnection *)xpcConnection
+- (instancetype)initWithControllerOverXPC:(MTRDeviceControllerOverXPC *)controllerOverXPC
+                                 deviceID:(NSNumber *)deviceID
+                            xpcConnection:(MTRDeviceControllerXPCConnection *)xpcConnection
 {
-    _controllerID = controllerID;
-    _controller = controller;
+    _controllerID = controllerOverXPC.controllerID;
+    _controller = controllerOverXPC;
     _nodeID = deviceID;
     _xpcConnection = xpcConnection;
     return self;

diff --git a/src/darwin/Framework/CHIPTests/MTRXPCListenerSampleTests.m b/src/darwin/Framework/CHIPTests/MTRXPCListenerSampleTests.m
@@ -520,6 +520,7 @@ - (void)waitForCommissionee
                    NSLog(@"Listener is not active");
                    return nil;
                }];
+    mConnectedDevice = [MTRBaseDevice deviceWithNodeID:@(kDeviceId) controller:remoteController];
     mDeviceController = remoteController;
 }