-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge revised tobyfigs into master #8
Conversation
…ename has to be put in by hand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only found one problem: heat-plot35.tiff clearly looks different when I make it on my computer
compared to what is stored in git. I can email you my version if you'd like, a png is
It looks like at least the x-axis has changed from linear to logarithmic.
I guess there's one more thing. Cairo should be included in packrat.lock. Possibly, just make these changes:
+Package: Cairo
+Source: CRAN
+Version: 1.5-9
+
Thanks, the figure previously in the branch had an extended x range, to include data at lower reporting probability. The code generated the figure used in the paper (Fig 5), which only shows reporting_prob > 0.01. I have changed the figure in the branch to the figure generated by the code. |
I've added cairo to packrat. I'm not sure how to check it is working correctly. |
I've successfully used packrat::restore to install Cairo based on packrat.lock, so I think it is working. |
Updates to figures
a) changed y-axis for high-low and snapshots plots from AUC to |AUC - 05|
b) added additional simulation data and suplemental figures to heat-map plot