Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge revised tobyfigs into master #8

Merged
merged 9 commits into from
Feb 26, 2018
Merged

Merge revised tobyfigs into master #8

merged 9 commits into from
Feb 26, 2018

Conversation

tsbrett
Copy link
Contributor

@tsbrett tsbrett commented Feb 20, 2018

Updates to figures
a) changed y-axis for high-low and snapshots plots from AUC to |AUC - 05|
b) added additional simulation data and suplemental figures to heat-map plot

Copy link
Contributor

@e3bo e3bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only found one problem: heat-plot35.tiff clearly looks different when I make it on my computer
compared to what is stored in git. I can email you my version if you'd like, a png is
heat-plot35
It looks like at least the x-axis has changed from linear to logarithmic.

I guess there's one more thing. Cairo should be included in packrat.lock. Possibly, just make these changes:
+Package: Cairo
+Source: CRAN
+Version: 1.5-9
+

@tsbrett
Copy link
Contributor Author

tsbrett commented Feb 26, 2018

Thanks, the figure previously in the branch had an extended x range, to include data at lower reporting probability. The code generated the figure used in the paper (Fig 5), which only shows reporting_prob > 0.01.

I have changed the figure in the branch to the figure generated by the code.

@tsbrett
Copy link
Contributor Author

tsbrett commented Feb 26, 2018

I've added cairo to packrat. I'm not sure how to check it is working correctly.

@e3bo
Copy link
Contributor

e3bo commented Feb 26, 2018

I've successfully used packrat::restore to install Cairo based on packrat.lock, so I think it is working.

@e3bo e3bo merged commit e52d442 into master Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants