Run civix.upgrade #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the code now-replaced by mixins. Rather than commit the mixin folder I incremented the version, leaving the older version still in play for older releases. The mixin folder is required for releases <=v5.44 - which is older than the various security updates so reducing code for the future feels more useful than preserving one release for before & after that https://civicrm.org/blog/totten/civix-v2205-how-remove-million-lines-extra-code
wmfgerrit
pushed a commit
to wikimedia/wikimedia-fundraising-crm
that referenced
this pull request
Sep 27, 2022
https: //github.com/progressivetech/net.ourpowerbase.exportpermission/pull/8 Bug: T318304 Change-Id: I244f6b5eb1ae5eebcc25f0d02781addc60dcd2ab
|
Thanks Eileen - It looks like you bumped the CiviCRM version to 5.53 - could that be 5.45 instead? Or is there a reason this change will break on, say, 5.51? |
|
@jmcclelland no - no reason it would break - my practice is always to bump to the version I test on - it could be lower (although as a highly optional update this is probably mostly about cleaning up master / for the future) |
|
Thanks Eileen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the code now-replaced by mixins. Rather than commit the mixin folder I incremented the version, leaving the older version still in play for older releases. The mixin folder is required for
releases <=v5.44 - which is older than the various security updates
so reducing code for the future feels more useful than preserving one release for before & after that
https://civicrm.org/blog/totten/civix-v2205-how-remove-million-lines-extra-code