Update code to make use of the cleanup that has been done on search tasks #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asks. Earlier in the 5.x series Matt Wire did a big cleanup on search tasks & we can use this now. I'm not sure exactly which release but 5.6 is the current one so just picking that seems fine. Since this was not previously on the extensions directly I think the current 'user' is PTP & I don't expect Jamie to have any difficulty navigating not deploying the version with the cleaned up code on old Civi releases (I think 5.3 actually does have the fixes in it which is possibly what you are on
|
Thanks Eileen. The tasks changes don't seem to be in 5.3, but I think it's better to start off on the right foot so I'm going to merge and keep our sites behind until we upgrade to 5.6. |
wmfgerrit
pushed a commit
to wikimedia/wikimedia-fundraising-crm
that referenced
this pull request
Nov 20, 2018
Note there is a big discussion here https://lab.civicrm.org/dev/core/issues/494 about this and I submitted a PR here progressivetech/net.ourpowerbase.exportpermission#2 to tweak this extension (basically cleanup) DEPLOYMENT NOTE - we need to add a permission to appropriate contacts when we deploy this - I don't know of any easy code way so was looking just to do it manually. Bug: T208270 Change-Id: I7d4c2a16298ff0574536e3b7261e760fa116c3b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier in the 5.x series @mattwire did a big cleanup on search tasks & we can use this now. I'm not sure exactly which release but 5.6 is the current one so just picking that seems fine.
Since this was not previously on the extensions directly I think the current 'user' is PTP & I don't expect @jmcclelland to have any difficulty navigating not deploying the version
with the cleaned up code on old Civi releases (I think 5.3 actually does have the fixes in it which is possibly what you are on)