Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with PHPStan v1.0 #49

Closed
wants to merge 1 commit into from
Closed

Add compatibility with PHPStan v1.0 #49

wants to merge 1 commit into from

Conversation

porozhnyy
Copy link

@porozhnyy porozhnyy commented Jan 8, 2022

#47
@marmichalski @akondas Hey! Maybe you can check this PR?

Copy link
Contributor

@marmichalski marmichalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed.
I am ok with ignoring the errors related to backward compatibility promise, that's what I did as I have also been working on bringing phpstan 1.x support, but due to time constraints did not finish yet 😿.

@porozhnyy
Copy link
Author

CI failed. I am ok with ignoring the errors related to backward compatibility promise, that's what I did as I have also been working on bringing phpstan 1.x support, but due to time constraints did not finish yet crying_cat_face.

Due to lack of time, I also do not have time to fix them, I decided to open PR in the hope that someone will correct them. I will try to find the time and solve all the problems in the coming days

@marmichalski
Copy link
Contributor

Done in #50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants