Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated snmpm:sync_get/4 by snmpm:sync_get2/4 #416

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ariel-anieli
Copy link

@ariel-anieli ariel-anieli commented Nov 19, 2024

@prefiks
Copy link
Member

prefiks commented Nov 20, 2024

I am not sure if those changes are sufficient, gen_statem requires for example callback_mode() hook that i think is missing, and i think it also adds extra argument to state callback functions it calls, so i am not sure if this will be working as expected.

@ariel-anieli ariel-anieli changed the title replace deprecated gen_fsm & snmpm:sync_get/4 replace deprecated snmpm:sync_get/4 by snmpm:sync_get2/4 Nov 20, 2024
@ariel-anieli
Copy link
Author

I am not sure if those changes are sufficient, gen_statem requires for example callback_mode() hook that i think is missing, and i think it also adds extra argument to state callback functions it calls, so i am not sure if this will be working as expected.

Thanks for the feedback, @prefiks; I reduced the scope of the PR to snmpm:sync_get/4.
I'll work on gen_statem in another PR: there is indeed a conversion guide from gen_fsm.

@ariel-anieli
Copy link
Author

Hello; any news on the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants