Fix bug in ortho() where using it without arguements, drawing failed in some cases, resolved. #6639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6621
Changes:
In src/webgl/p5.Camera.js :
if (far === undefined) far = Math.max(this._renderer.width, this._renderer.height)+800;
In test/unit/webgl/p5.Camera.js :
var expectedMatrix = new Float32Array([ 0.019999999552965164, 0, 0, 0, 0, -0.019999999552965164, 0, 0, 0, 0, -0.002222222276031971, 0, -0, -0, -1, 1 ]);
Screenshots of the change:
Before:
PR Checklist
npm run lint
passes