PlatformIO #144
Merged
PlatformIO #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAssassin
commented
Mar 7, 2020
| - if [[ "$BD" =~ "esp32:esp32:" ]]; then git clone https://github.com/bbx10/Hash_tng ; fi | ||
| - cd - | ||
| - sudo apt-get update && sudo apt-get install -y --no-install-recommends python3-minimal python3-pip python3-setuptools | ||
| - pip3 install platformio==4.2.1 |
There was a problem hiding this comment.
I just pinned it because you prefer that it seems. I don't think there'll be issues with any PlatformIO version >= 4, though. Pinning the dependencies makes sense indeed.
|
As a matter of policy I want to pin everything in this project as it has proven to be flaky. That it compiles does not mean that it works, and I have already lost much time due to this fact. |
|
I think the way PlatformIO allows for pinning dependencies is straightforward, and most of it has been taken from the commands in the Travis config. Can you test the binaries which are built by PlatformIO perhaps? I don't have any SD card hardware nor a printer with serial pins right now. Edit: nevermind. |
|
A big thank you @TheAssassin 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please update your README accordingly to replace that awkward series of calls to the Arduino IDE etc. with e.g., a link to the PlatformIO docs.