Skip to content
This repository has been archived by the owner on Sep 25, 2024. It is now read-only.

Migrate to warnings ng plugin #31

Merged
merged 4 commits into from
Mar 4, 2022

Conversation

tobias-richter
Copy link
Contributor

No description provided.

@tobias-richter
Copy link
Contributor Author

@tobias-richter tobias-richter marked this pull request as ready for review March 2, 2022 09:22
@tobias-richter tobias-richter requested a review from bellackn March 2, 2022 09:23
Copy link
Member

@bellackn bellackn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my local unit tests are failing with

Groovyc: unable to resolve class io.wcm.devops.jenkins.pipeline.utils.resources.YamlLibraryResource

and

Groovyc: unable to resolve class io.wcm.devops.jenkins.pipeline.utils.logging.Logger

-- but this also happens for me on the master branch, so probably a local problem.
so, afaic, lgtm 👍

@tobias-richter
Copy link
Contributor Author

@bellackn you may have to run mvn clean install in the pipeline-library first before this branch will build correctly

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #31 (6f303eb) into master (b20a41f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #31   +/-   ##
=========================================
  Coverage     83.78%   83.78%           
  Complexity       11       11           
=========================================
  Files             1        1           
  Lines            37       37           
  Branches          6        6           
=========================================
  Hits             31       31           
  Misses            1        1           
  Partials          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b20a41f...6f303eb. Read the comment docs.

@tobias-richter tobias-richter merged commit 80bab24 into master Mar 4, 2022
@tobias-richter tobias-richter deleted the feature/migrate-to-warnings-ng-plugin branch March 4, 2022 16:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants