Reduce duplicated code involved in running a query #683
Conversation
In particular, this makes there be only one copy of the code that processes the input reports for an IPA query.
|
This is scaled back a bit from what I had originally tried to do. I tried to make the query processing generic over the return type of the query, i.e., a query would return |
| while let Some(data) = input.next().await { | ||
| input_vec.extend(IPAInputRow::<F, MatchKey, BreakdownKey>::from_byte_slice( | ||
| &data.unwrap(), | ||
| )); |
There was a problem hiding this comment.
The big win is that there's only one copy of this code that does input.align and the subsequent processing of the inputs. It's only a few lines right now, but it's about to get a bit more involved.
| &'a PrssEndpoint, | ||
| &'a Gateway, | ||
| ByteArrStream, | ||
| ) -> Pin<Box<dyn Future<Output = QueryResult> + Send + 'a>> |
There was a problem hiding this comment.
This box is needed only because having two type parameters for the function and the returned future prevents describing the HRTB for the 'a lifetime.
There was a problem hiding this comment.
I'm still amazed at how you can operate with lifetime traits. I like rust, but hate having to deal with lifetimes. It's as though the language was designed to suck you in and then trap you in a Kafkaesque nightmare filled with unbalanced quotes.
| &'a PrssEndpoint, | ||
| &'a Gateway, | ||
| ByteArrStream, | ||
| ) -> Pin<Box<dyn Future<Output = QueryResult> + Send + 'a>> |
There was a problem hiding this comment.
I'm still amazed at how you can operate with lifetime traits. I like rust, but hate having to deal with lifetimes. It's as though the language was designed to suck you in and then trap you in a Kafkaesque nightmare filled with unbalanced quotes.
| config: QueryConfig, | ||
| gateway: Gateway, | ||
| input: ByteArrStream, | ||
| ) -> JoinHandle<QueryResult> { | ||
| match (config.query_type, config.field_type) { |
There was a problem hiding this comment.
This is a bit repetitious, but I think that this is a reasonable amount of repetition to manage.
| field: FieldType, | ||
| impl<F, C, S, SB> IpaQuery<F, C, S> | ||
| where | ||
| C: UpgradableContext + Send, |
In particular, this makes there be only one copy of the code that processes the input reports for an IPA query.