Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

[Feature] Add Contrib/Non-free Tag #687

Merged
merged 21 commits into from
Jun 20, 2019
Merged

Conversation

asddsaz
Copy link
Contributor

@asddsaz asddsaz commented Dec 23, 2018

Description: Add contrib tag to software that recommends or depends on non-free software.
What is contrib? Contrib is a term created by the Debian Foundation to discern from software that is free software but may depend on non-free software.
But, isn't everything listed on privacytools.io only free software? Nope, especially not OSes of which many will auto-install non-free firmware like QubesOS.

@ghost
Copy link

ghost commented Dec 23, 2018

Please add the labels the same way Brave's experimental label is added.

@ghost
Copy link

ghost commented Dec 23, 2018

Note that you can't use " or , in the labels attribute. I will write a wiki page about this sometime.

For commas you can use ,.

@Mikaela
Copy link
Contributor

Mikaela commented Dec 23, 2018

Should something be done to apps that are free and use free servers, but where server is not configurable, for example Signal?

@ghost
Copy link

ghost commented Dec 23, 2018

With Wire we warn about plaintext metadata. If Signal's open source frontend encrypts everything, there's nothing to warn about.

@asddsaz
Copy link
Contributor Author

asddsaz commented Dec 24, 2018

Please add the labels the same way Brave's experimental label is added.

@Shifterovich Done!

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@asddsaz
Copy link
Contributor Author

asddsaz commented Dec 24, 2018

@Shifterovich Would you mind plz explaining the requested changes. I do not understand. :)

@ghost
Copy link

ghost commented Dec 24, 2018

You added the labels=... but kept the <span class="badge badge-warning" data-toggle="tooltip" title="This ... in the description.

@asddsaz
Copy link
Contributor Author

asddsaz commented Dec 24, 2018

@Shifterovich Hmm, try re-pulling. I only see it for LineageOS. I made sure to fix that. :)
Thank you so much for your help!

@ghost
Copy link

ghost commented Dec 24, 2018

Yeah, the issue with the description is now fixed.


This software may depend on or recommend non-free software.

How do you mean recommend?

@asddsaz
Copy link
Contributor Author

asddsaz commented Dec 24, 2018

@Shifterovich So, one example would be that Ubuntu "recommends" non-free software like Steam.

The main issue with the items I want to currently add this to is firmware but if an OS/App recommends a user to install non-free software you could use the same tag.
Preferably, it would have a more specific warning like:

This software may recommend non-free software such as apps or addons.

It is meant to warn the user that although the app is free software it may ask to install non-free software.

@ghost
Copy link

ghost commented Dec 24, 2018

In what way does Ubuntu recommend Steam? (If it does, I haven't noticed.)

@asddsaz
Copy link
Contributor Author

asddsaz commented Dec 25, 2018

In what way does Ubuntu recommend Steam? (If it does, I haven't noticed.)

During installation they show many apps available for Ubuntu, many are non-free. They also have many non-free apps in their App Store.

The FSF/GNU has a good article on this:

Ubuntu provides specific repositories of nonfree software, and Canonical expressly promotes and recommends nonfree software under the Ubuntu name in some of their distribution channels. Ubuntu offers the option to install only free packages, which means it also offers the option to install nonfree packages too. In addition, the version of Linux, the kernel, included in Ubuntu contains firmware blobs.

The “Ubuntu Software Center” lists proprietary programs and free programs jumbled together. It is hard to tell which ones are free since proprietary programs for download at no charge are labelled “free”.

Source: http://www.gnu.org/distros/common-distros.html

ghost
ghost previously approved these changes Dec 25, 2018
@ghost ghost requested a review from Vincevrp December 25, 2018 09:54
index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@Vincevrp Vincevrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some screenshots?

@asddsaz
Copy link
Contributor Author

asddsaz commented Dec 31, 2018

Could you please add some screenshots?

Hopefully this gives you kinda an idea:

image

@Vincevrp @Shifterovich

@privacytoolsIO
Copy link
Contributor

hi guys, whats the status here?

Copy link
Contributor

@Mikaela Mikaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to have became outdated/merge conflicting due to the website update. I would also like to see how this looks in practice and I think Netlify integration would kick in and bring a preview when the PR is updated.

@Mikaela Mikaela requested review from privacytoolsIO, a team and Vincevrp April 21, 2019 20:43
ghost
ghost previously approved these changes May 13, 2019
jonaharagon
jonaharagon previously approved these changes May 13, 2019
Copy link
Contributor

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a relatively minor change to the operating systems sections only, so I'm okay with merging this.

@asddsaz
Copy link
Contributor Author

asddsaz commented May 17, 2019

There appears to have been couple of OSes with non-free kernels I must've forgotten to add the label to.
(mainly just DD-WRT, Whonix, and SubgraphOS)
But, wanted to inform you on why the extra commits.

@Shifterovich @jonaharagon @Mikaela @blacklight447-ptio

Like Before, OSes like Arch that list free'd alternatives don't need to tag.
Since, they say state that they aren't fully free in their description.

@asddsaz asddsaz dismissed stale reviews from jonaharagon, ghost , and Mikaela via 841434b May 17, 2019 04:47
@Mikaela Mikaela requested review from a user, jonaharagon and Mikaela and removed request for a user and jonaharagon May 17, 2019 09:25
@asddsaz
Copy link
Contributor Author

asddsaz commented May 30, 2019

Aye, I was just curious if any of the past reviews have changed.
If they have, is there any changes that you would like undone or reverted or changed?

There hasn't been a discussion here is a while. :)

@jonaharagon @Shifterovich @Mikaela

Copy link
Contributor

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I overall approve of this PR but it has some strange code style related things that should be fixed.

index.html Outdated Show resolved Hide resolved
_includes/sections/live-operating-systems.html Outdated Show resolved Hide resolved
asddsaz and others added 2 commits June 6, 2019 21:31
Co-Authored-By: Jonah Aragon <jonah@triplebit.net>
Co-Authored-By: Jonah Aragon <jonah@triplebit.net>
@Mikaela Mikaela removed their request for review June 8, 2019 17:16
@jonaharagon
Copy link
Contributor

Okay well, I suppose I'll go ahead and merge this 🤞

@jonaharagon jonaharagon merged commit ace1ef6 into privacytools:master Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants