Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Add experimental label to Brave, add tooltip support for labels #661

Closed
wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 13, 2018

Description

See #657

Resolves: #161

Screenshots

screenshot from 2018-12-13 22-15-33

The tooltip text can be changed. @Vincevrp feel free to change it

@ghost ghost mentioned this pull request Dec 13, 2018
@ghost
Copy link
Author

ghost commented Dec 13, 2018

The index.html diff isn't displayed in the PR, but it does work in terminal now (so it presumably will work after merge).

screenshot from 2018-12-13 22-23-46

@ghost ghost assigned Vincevrp Dec 13, 2018
@ghost ghost requested a review from Vincevrp December 13, 2018 21:29
@ghost ghost added the high priority label Dec 13, 2018
@ghost
Copy link
Author

ghost commented Dec 15, 2018

@Vincevrp I'm closing this and pushing the changes to master due to the conflics, but please review the tooltip message:

labels="warning:experimental:Brave is a good choice if you want to use a Chromium-based browser. But at this point in Brave's development, it's not as good as Firefox with privacy addons."

@ghost ghost closed this Dec 15, 2018
@ghost ghost deleted the brave-label branch December 15, 2018 15:58
@qmontal
Copy link

qmontal commented Dec 17, 2018

@Shifterovich thank you for your patience and commitment through the whole discussion and process, you handled it amazingly! Hoping for Brave to improve :)

@ghost
Copy link
Author

ghost commented Dec 17, 2018

Thanks :)

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Brave
2 participants