Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Real time communication improvements #1147

Merged
merged 19 commits into from
Aug 17, 2019
Merged

Real time communication improvements #1147

merged 19 commits into from
Aug 17, 2019

Conversation

Mikaela
Copy link
Contributor

@Mikaela Mikaela commented Aug 12, 2019

Resolves: #1137

  • Remove duplicate Signal & Wire (which also fixes Wire VoIP warning being wrong)
  • Move Tox and Jami to instant messengers
  • Change Jitsi to Jitsi Meet
  • List Mumble

Resolves: #967

  • Remove Signal Desktop platforms as Android/iOS is required.

References: #1071

List security audits for:

  • Signal
  • Wire
  • Keybase

Preview: https://deploy-preview-1147--privacytools-io.netlify.com/software/real-time-communication/

also move Tox and Jami to Instant Messengers, Change Jitsi to Jitsi Meet
@netlify
Copy link

netlify bot commented Aug 12, 2019

Deploy preview for privacytools-io ready!

Built with commit 9235f50

https://deploy-preview-1147--privacytools-io.netlify.com

Copy link
Contributor Author

@Mikaela Mikaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My usual commentary

@@ -15,9 +15,6 @@ <h1 id="im" class="anchor"><a href="#im"><i class="fas fa-link anchor-icon"></i>
github="https://github.com/signalapp"
android=""
ios=""
mac=""
windows=""
linux=""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #967

_includes/sections/instant-messenger.html Outdated Show resolved Hide resolved
<li><a href="https://eprint.iacr.org/2016/1013.pdf">A Formal Security Analysis of the Signal Messaging Protocol (2019)</a> by Katriel Cohn-Gordon, Cas Cremers, Benjamin Dowling, Luke Garratt and Douglas Stebila</li>
<li><a href="https://wire.com/en/security/#audits">Indepedent security audits</a> on Wire's website</li>
<li><a href="https://keybase.io/docs-assets/blog/NCC_Group_Keybase_KB2018_Public_Report_2019-02-27_v1.3.pdf">Keybase's Protocol Security Review (2019)</a> by <a href="https://www.nccgroup.trust/">NCC Group</a></li>
</ul>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same order we list them in on the page.

_includes/sections/voice-video-messenger.html Outdated Show resolved Hide resolved


{% include cardv2.html
title="Mumble"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested it in #1137 and thus had to remove encrypted from the title. @nitrohorse OKed it, but I understand if you wish to remove it.

I think Mumble may be more beginner friendly than Linphone and currently the only other suggestion is Jitsi Meet, which requires WebRTC that many are going to have disabled thanks to the Firefox tweaks.

title="Mumble"
image="/assets/img/tools/Mumble.png"
website="https://mumble.info/"
description="Mumble is an open source, low-latency, high quality voice chat software primarily intended for use while gaming. <span class=\"badge badge-warning\" data-toggle=\"tooltip\" title=\"\">Warning</span> While Mumble doesn't log messages or record by default, <a href=\"https://github.com/mumble-voip/mumble/issues/1813\">it's missing end-to-end encryption</a>, so self-hosting is recommended."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also the related information section

_includes/sections/voice-video-messenger.html Outdated Show resolved Hide resolved
<li>More information about Mumble:</li>
<ul>
<li><a href="https://wiki.mumble.info/wiki/Running_Murmur">Running Mumble Server</a> and <a href="https://wiki.mumble.info/wiki/Murmur.ini">its config file</a>, particularly <a href="https://wiki.mumble.info/wiki/Murmur.ini#obfuscate">obfuscating IPv4 addresses</a> and <a href="https://wiki.mumble.info/wiki/Murmur.ini#Process_Administrivia">logging</a></li>
<li><a href="https://trac.torproject.org/projects/tor/wiki/doc/TorifyHOWTO/Mumble">Torifying Mumble</a>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may make Mumble more privacy friendly than Jitsi Meet, presuming logging is disabled. Tor Browser disables WebRTC, doesn't it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just validated myself and it's disabled in about:config.

@@ -136,26 +136,24 @@ Backend: closed-source

Ricochet: https://github.com/ricochet-im/ricochet

Tox: https://github.com/TokTok/c-toxcore

Ring/Jami: https://git.jami.net/savoirfairelinux
Copy link
Contributor Author

@Mikaela Mikaela Aug 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I corrected the source code location for Jami. Otherwise I just moved things around.

@Mikaela Mikaela marked this pull request as ready for review August 12, 2019 10:42
@Mikaela
Copy link
Contributor Author

Mikaela commented Aug 12, 2019

Would there be any point in listing Signal desktop separately and saying that it needs to be linked to Signal mobile?

Copy link
Contributor

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes at https://github.com/Mikaela/privacytools.io/pull/1 I'd like to see included, otherwise LGTM.

I also can't decide if we should include a Supports VoIP badge on the Instant Messengers that support VoIP, because we removed them from the Voice section. I just want it to be clear that Signal/Wire also support Voice. But maybe the warning listed is enough. I'm very on the fence about it. If we do want to add a badge like that though, I need the cardv2.html changes I made in #1148 to be merged first.

@jonaharagon jonaharagon reopened this Aug 13, 2019
@@ -60,6 +57,8 @@ <h3>Worth Mentioning</h3>
<li><a href="https://keybase.io/">Keybase</a> - <span class="badge badge-warning" data-toggle="tooltip" title="This software relies on a closed-source central server.">Warning</span> End-to-end encrypted messaging with social verification.</li>
<li><a href="https://status.im/">Status</a> - <span class="badge badge-warning">Experimental</span> A free and open-source, peer-to-peer, encrypted instant messanger with support for DAPPs.</li>
<li><a href="https://ricochet.im/">Ricochet</a> - <span class="badge badge-danger" data-toggle="tooltip" title="This software is safe if you manually keep Tor up to date."><a href="#ricochetTor" class="text-white">Danger</a></span> <span class="badge badge-warning" data-toggle="tooltip" title="This software is considered safe but experimental and the client has not been updated since 2016."><a href="https://github.com/ricochet-im/ricochet#experimental">Experimental</a></span> Ricochet uses the <a href="/browsers/#browser"><i class="fas fa-link"></i> Tor network</a> to reach your contacts without relying on messaging servers. It creates a hidden service, which is used to rendezvous with your contacts without revealing your location or IP address.</li>
<li> <a href="https://tox.chat/">Tox</a> - <span class="badge badge-warning">Experimental</span> A free and open-source, peer-to-peer, encrypted instant messaging and video calling software. </li>
<li><a href="https://jami.net/">Jami (formerly Ring/SFLphone)</a> - Gives you a full control over your communications and an unmatched level of privacy. Jami has <em>text messaging, video and audio calls, file transfer, video conferencing</em>.</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion; remove "a": Gives you full control...

@nitrohorse
Copy link
Contributor

I also can't decide if we should include a Supports VoIP badge on the Instant Messengers that support VoIP, because we removed them from the Voice section. I just want it to be clear that Signal/Wire also support Voice. But maybe the warning listed is enough. I'm very on the fence about it.

Looking it over I think adding a badge would be a good idea. The callout in the warning alert is kind of easy to miss.

Otherwise, LGTM too!

nitrohorse
nitrohorse previously approved these changes Aug 13, 2019
Copy link
Contributor

@nitrohorse nitrohorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once comments are resolved 👍

@Mikaela
Copy link
Contributor Author

Mikaela commented Aug 13, 2019

So I just need to warn about WebRTC and Minor suggestion; remove "a": Gives you full control...?

Do I need to somehow add the supports VoIP label or will @jonaharagon do that later?

@Mikaela
Copy link
Contributor Author

Mikaela commented Aug 13, 2019

@jonaharagon @nitrohorse How about this?

@Mikaela
Copy link
Contributor Author

Mikaela commented Aug 13, 2019

image

I am going to cancel that last commit though as I think it looks better with the space.

The labels/badges functionality added to cardv2.html in cbe5de4 work better here.
Copy link
Contributor

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K last change: Since #1148 was merged the changes I pushed to Mikaela#2 make more sense for the VoIP and other badges.

@Mikaela Mikaela requested a review from jonaharagon August 13, 2019 19:27
jonaharagon
jonaharagon previously approved these changes Aug 13, 2019
nitrohorse
nitrohorse previously approved these changes Aug 14, 2019
Copy link
Contributor

@nitrohorse nitrohorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@jonaharagon jonaharagon dismissed stale reviews from nitrohorse and themself via 9235f50 August 17, 2019 02:33
@jonaharagon jonaharagon merged commit 1947b84 into privacytools:master Aug 17, 2019
@jonaharagon jonaharagon deleted the rtc-improvements branch August 17, 2019 02:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Real-Time Communication ideas 💬 Discussion | How many platforms does signalapp REALLY support?
3 participants