Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Add criteria to VPN Services page and update other sections #2788

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

I-I-IT
Copy link
Contributor

@I-I-IT I-I-IT commented Oct 27, 2024

List of changes proposed in this PR:

-It adds much needed information about Mullvad's new obfuscation tech, fixes a few quirks and add some info. More importantly, I introduced new criterias that all current VPN providers meet. Of course, those might need discussion in the forum.

Original changelog:

Justifcation for a few of the changes. First, while Proton technically has ipv6 support on Linux, it didn't work for me, so I didn't include it. Second, the requirements for FDE/ram servers make sense to prevent logging by malicious employees. Mullvad/IVPN are ram-only while Proton has FDE. Third, the requirements for the jurisdiction is to prevent cases like RiseUP VPN (https://riseup.net/en/about-us/press/canary-statement).

Copy link

github-actions bot commented Oct 27, 2024

Your preview is ready!

Name Link
🔨 Latest commit 1c30ca8
😎 Preview https://2788--glowing-salamander-8d7127.netlify.app/

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides Community. There might be relevant details there:

https://discuss.privacyguides.net/t/new-vpn-criterias-and-update-the-page/21864/1

@I-I-IT I-I-IT requested a review from jonaharagon as a code owner October 27, 2024 19:58
docs/vpn.md Outdated Show resolved Hide resolved
docs/vpn.md Outdated Show resolved Hide resolved
docs/vpn.md Outdated Show resolved Hide resolved
docs/vpn.md Outdated Show resolved Hide resolved
docs/vpn.md Outdated Show resolved Hide resolved
docs/vpn.md Outdated Show resolved Hide resolved
docs/vpn.md Outdated Show resolved Hide resolved
docs/vpn.md Outdated Show resolved Hide resolved
docs/vpn.md Show resolved Hide resolved
includes/abbreviations.en.txt Outdated Show resolved Hide resolved
@friadev friadev changed the title Update VPN section info, complete it and add some criterias update: VPN section info, complete it and add some criterias Oct 28, 2024
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with all of @friadev's suggested changes here.

docs/vpn.md Outdated Show resolved Hide resolved
Copy link
Member

@redoomed1 redoomed1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

In addition to the changes I suggested below, the IPv6 entry for Proton VPN in the randomized table should be updated as well. | Done here: 25fcc8c

docs/vpn.md Outdated Show resolved Hide resolved
docs/vpn.md Outdated Show resolved Hide resolved
docs/vpn.md Outdated Show resolved Hide resolved
docs/vpn.md Outdated Show resolved Hide resolved
docs/vpn.md Outdated Show resolved Hide resolved
@redoomed1 redoomed1 added c:providers service providers and similar centralized/federated services t:correction content corrections or errors labels Oct 29, 2024
@redoomed1 redoomed1 changed the title update: VPN section info, complete it and add some criterias update: Add criteria to VPN Services page and update other sections Oct 29, 2024
Copy link
Member

@redoomed1 redoomed1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your work incorporating all of our feedback! I suggest some changes below for consistency reasons (making most of the criteria noun phrases), but the PR overall looks good to me.

docs/vpn.md Outdated Show resolved Hide resolved
docs/vpn.md Outdated Show resolved Hide resolved
docs/vpn.md Outdated Show resolved Hide resolved
docs/vpn.md Outdated Show resolved Hide resolved
docs/vpn.md Outdated Show resolved Hide resolved
docs/vpn.md Outdated Show resolved Hide resolved
@I-I-IT
Copy link
Contributor Author

I-I-IT commented Nov 1, 2024

Thanks for all your work incorporating all of our feedback! I suggest some changes below for consistency reasons (making most of the criteria noun phrases), but the PR overall looks good to me.

You are welcome, I'm glad we can quickly update sections because it is important for PG credibility. I take this opportunity to ask you to please review my Pull Request about private AI chat (preview)

docs/vpn.md Outdated Show resolved Hide resolved
docs/vpn.md Outdated Show resolved Hide resolved
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides Community. There might be relevant details there:

https://discuss.privacyguides.net/t/add-ai-chat-tools/14347/164

…rivacyguides#2788)

Updates include:
- Obfuscation info, ProtonVPN IPv6 and added missing download links
- added a few criteria

Testing:
- Proton has IPv6 support on Linux but it didn't work for me
- Requirements for FDE/ram servers make sense to prevent logging by malicious employees.
- Mullvad/IVPN are ram-only while Proton has FDE.
- Requirements for the jurisdiction is to prevent cases like RiseupVPN (https://riseup.net/en/about-us/press/canary-statement).

Co-authored-by: redoomed1 <161974310+redoomed1@users.noreply.github.com>
Co-authored-by: fria <138676274+friadev@users.noreply.github.com>
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray merged commit 1c30ca8 into privacyguides:main Nov 10, 2024
9 checks passed
@I-I-IT I-I-IT deleted the patch-10 branch November 10, 2024 11:26
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides Community. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-11-11/22347/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:providers service providers and similar centralized/federated services t:correction content corrections or errors
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants