Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Password Managers page #2624

Merged
merged 1 commit into from
Jul 6, 2024
Merged

fix: Update Password Managers page #2624

merged 1 commit into from
Jul 6, 2024

Conversation

redoomed1
Copy link
Member

Changes proposed in this PR:

  • Proton Pass
    • Remove the last section of the description
      • The Proton Mail card already mentions that the service is based in Switzerland (which is visible when hovering over the internal link), and the other pieces of information are, in my opinion, not useful for readers.
    • Bold the first instance of "Proton Pass" in the description for consistent styling
  • 1Password
    • Remove the last paragraph below the 1Password card comparing 1Password to Bitwarden, and integrate the parts highlighting 1Password's features into the first paragraph
    • Unbold "1Password" in the first sentence of the text below the card for consistent styling
  • Change the icons for Proton Pass's and 1Password's web app links so that they're consistent with the icons for other web app links (see the ones on the Calendar Sync page)
  • Update Psono's description to mention its limited passkey support
  • Fix grammar in the description for KeePassDX
  • I agree to the terms listed below:
    Contribution terms (click to expand) 1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.

@redoomed1 redoomed1 mentioned this pull request Jun 26, 2024
2 tasks
@dngray
Copy link
Member

dngray commented Jul 6, 2024

LGTM. I think we can merge this.

- Fix bold of consistency of some items
- Proton card already mentions service is in Switzerland
- Tidy up 1Password description
- Change the icons for Proton Pass's and 1Password's web app links so that they're consistent with the icons for other web app links
- Update Psono's description to mention its limited passkey support
- Grammar fixes

Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray merged commit 5facb99 into privacyguides:main Jul 6, 2024
5 of 6 checks passed
@redoomed1 redoomed1 deleted the update-password-managers branch July 6, 2024 22:58
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-07-15/19478/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants