Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit recommendations meta page #2604

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Commit recommendations meta page #2604

merged 1 commit into from
Jun 3, 2024

Conversation

dngray
Copy link
Member

@dngray dngray commented Jun 2, 2024

Changes proposed in this PR:

  • I agree to the terms listed below:
    Contribution terms (click to expand) 1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.

dngray added a commit that referenced this pull request Jun 2, 2024
@dngray dngray force-pushed the pr-commit-messages branch from 1f2dbc4 to 77627e3 Compare June 2, 2024 03:34
@dngray dngray changed the title update: Add commit messages meta page Commit recommendations meta page Jun 2, 2024
Copy link

github-actions bot commented Jun 2, 2024

Your preview is ready!

Name Link
🔨 Latest commit 8efc938
😎 Preview https://2604--glowing-salamander-8d7127.netlify.app/

dngray added a commit that referenced this pull request Jun 2, 2024
@dngray dngray force-pushed the pr-commit-messages branch from 77627e3 to 2c4e5a5 Compare June 2, 2024 03:40
dngray added a commit that referenced this pull request Jun 2, 2024
@dngray dngray force-pushed the pr-commit-messages branch from 2c4e5a5 to 8efc938 Compare June 2, 2024 03:42
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can find some GitHub workflow to enforce conventional commit names 🤔

Copy link
Contributor

@rollsicecream rollsicecream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/meta/commit-messages.md Outdated Show resolved Hide resolved
docs/meta/commit-messages.md Outdated Show resolved Hide resolved
Copy link
Member Author

@dngray dngray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed LGTM.

Signed-off-by: redoomed1 <161974310+redoomed1@users.noreply.github.com>
Signed-off-by: Jonah Aragon <jonah@privacyguides.org>
@dngray dngray force-pushed the pr-commit-messages branch from e722ef4 to 6493cc2 Compare June 3, 2024 04:07
@dngray dngray merged commit 6493cc2 into main Jun 3, 2024
7 checks passed
@dngray dngray deleted the pr-commit-messages branch June 3, 2024 04:08
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-07-15/19478/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants