Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mention of ProtonVPN Linux clients not having 2FA #2539

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Remove mention of ProtonVPN Linux clients not having 2FA #2539

merged 1 commit into from
Apr 16, 2024

Conversation

jordan-warne
Copy link
Member

@jordan-warne jordan-warne commented Apr 15, 2024 •
edited
Loading

Changes proposed in this PR:

  • Remove mention of ProtonVPN Linux clients not having 2FA

They have released a new Linux client which supports 2FA using TOTP.

https://protonvpn.com/blog/vpn-linux-app/

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 15, 2024 •
edited
Loading

✅ Your preview is ready!

Name Link
🔨 Latest commit 266f928
😎 Preview https://2539--glowing-salamander-8d7127.netlify.app/

redoomed1
redoomed1 requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@redoomed1 redoomed1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same section under the IVPN recommendation mentions the IVPN clients supporting 2FA, so I think removing just the "except Linux at the moment" part is preferable.

jonaharagon
jonaharagon reviewed Apr 15, 2024
View reviewed changes
docs/vpn.md Outdated Show resolved Hide resolved
jonaharagon
jonaharagon reviewed Apr 15, 2024
View reviewed changes
docs/vpn.md Outdated Show resolved Hide resolved
jonaharagon
jonaharagon approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@jonaharagon jonaharagon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic, thanks!

jonaharagon added a commit that referenced this pull request Apr 15, 2024
@jonaharagon
https://github.com/privacyguides/privacyguides.org/pull/2539#pullrequ…
bb09e4b 
…estreview-2001854602
@jonaharagon jonaharagon mentioned this pull request Apr 15, 2024
Merged
4 tasks
@dngray dngray added c:providers service providers and similar centralized/federated services t:correction content corrections or errors labels Apr 16, 2024
dngray pushed a commit to jordan-warne/privacyguides.org that referenced this pull request Apr 16, 2024
@jordan-warne @redoomed1 @dngray
fix: ProtonVPN on Linux has 2FA (privacyguides#2539)
3130f6e 
Co-authored-by: redoomed1 <161974310+redoomed1@users.noreply.github.com>
Signed-off-by: Jonah Aragon <jonah@privacyguides.org>
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@jordan-warne @redoomed1 @dngray
fix: ProtonVPN on Linux has 2FA (privacyguides#2539)
266f928 
Co-authored-by: redoomed1 <161974310+redoomed1@users.noreply.github.com>
Signed-off-by: Jonah Aragon <jonah@privacyguides.org>
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray merged commit 266f928 into privacyguides:main Apr 16, 2024
6 checks passed
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-04-16/17905/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redoomed1 redoomed1 redoomed1 requested changes

@jonaharagon jonaharagon jonaharagon approved these changes

@dngray dngray dngray approved these changes

Assignees
No one assigned
Labels
c:providers service providers and similar centralized/federated services t:correction content corrections or errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jordan-warne @privacyguides-bot @jonaharagon @dngray @redoomed1