Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ALL knowledge base pages to HTML admonitions #2425

Merged

Conversation

rollsicecream
Copy link
Contributor

@rollsicecream rollsicecream commented Mar 5, 2024

Changes proposed in this PR:

  • Convert ALL knowledge base pages to HTML admonitions

  • I'd also like to take this opportunity to correct a typo in the "Common Threats page (Mass Surveillance programs section)" on the word "Technopolice" which was written as follows: "Technolopolice".

oof, that was a hell of a ride converting EVERY page of the website to HTML admonitions 😄

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 05e5832
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/65e9470e935bd90008e15f11
😎 Deploy Preview https://deploy-preview-2425.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
4 paths audited
Performance: 71 (🔴 down 5 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@rollsicecream rollsicecream force-pushed the html-admonitions-knowledge-base branch 4 times, most recently from d9d12cc to e5c4ad1 Compare March 5, 2024 22:33
@rollsicecream
Copy link
Contributor Author

rollsicecream commented Mar 5, 2024

There's just a tiny problem here :

Capture d’écran du 2024-03-05 23-33-46

Only the word "qubes" in the admonition title should be italic, but now almost everything is.....

If anyone could fix that, this would be great 🙂

@dngray
Copy link
Member

dngray commented Mar 7, 2024

Only the word "qubes" in the admonition title should be italic, but now almost everything is.....

That's very easy to fix, simply close the attribute for example you had <em>text<em> what you needed was <em>text</em>.

Also, thanks for the mega effort.

@dngray dngray force-pushed the html-admonitions-knowledge-base branch from e5c4ad1 to 9861de8 Compare March 7, 2024 04:43
@dngray dngray added the c:enhancements new features or other enhancements to the website itself label Mar 7, 2024
dngray pushed a commit to rollsicecream/privacyguides-fork that referenced this pull request Mar 7, 2024
@dngray dngray force-pushed the html-admonitions-knowledge-base branch from 9861de8 to d8828b9 Compare March 7, 2024 04:47
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray force-pushed the html-admonitions-knowledge-base branch from d8828b9 to 05e5832 Compare March 7, 2024 04:48
@dngray dngray merged commit 05e5832 into privacyguides:main Mar 7, 2024
@rollsicecream rollsicecream deleted the html-admonitions-knowledge-base branch March 23, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:enhancements new features or other enhancements to the website itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants