Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert 4 pages to HTML admonitions #2424

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

rollsicecream
Copy link
Contributor

@rollsicecream rollsicecream commented Mar 5, 2024

Changes proposed in this PR:

  • Convert

    • "Frontends" page
    • "Notebooks" page
    • "Password managers" page
    • "Productivity tools" page

To HTML admonitions.

And so, the HTML admonitions saga for the recommendations category has ended 🎉

But we now have to convert all Knowledge Base pages to HTML admonitions 😄

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 0140f0a
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/65e92c9224467f0008c8cbd4
😎 Deploy Preview https://deploy-preview-2424.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
4 paths audited
Performance: 76 (no change from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@rollsicecream rollsicecream force-pushed the mega-html-admonitions-2 branch 4 times, most recently from 7bbd72c to 70ef793 Compare March 5, 2024 18:16
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray added the c:enhancements new features or other enhancements to the website itself label Mar 7, 2024
@dngray dngray force-pushed the mega-html-admonitions-2 branch from 70ef793 to 0140f0a Compare March 7, 2024 02:55
@dngray dngray merged commit 0140f0a into privacyguides:main Mar 7, 2024
3 of 4 checks passed
@rollsicecream rollsicecream deleted the mega-html-admonitions-2 branch March 23, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:enhancements new features or other enhancements to the website itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants