Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the Messengers page to HTML admonitions #2383

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

rollsicecream
Copy link
Contributor

Changes proposed in this PR:

  • Convert the "Real-Time Communication" page, a.k.a. Messengers to use the new HTML admonitions.
  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

Copy link

netlify bot commented Jan 30, 2024

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit a1523e3
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/65ba2bdcd5e3b00008475162
😎 Deploy Preview https://deploy-preview-2383.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
4 paths audited
Performance: 71 (🔴 down 3 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 88 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@rollsicecream rollsicecream marked this pull request as ready for review January 30, 2024 16:51
dngray pushed a commit to rollsicecream/privacyguides-fork that referenced this pull request Jan 31, 2024
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray force-pushed the convert-html-messengers branch from c84e124 to da64a9e Compare January 31, 2024 11:14
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray force-pushed the convert-html-messengers branch from 85c869a to a1523e3 Compare January 31, 2024 11:15
@dngray dngray merged commit a1523e3 into privacyguides:main Jan 31, 2024
@dngray
Copy link
Member

dngray commented Jan 31, 2024

This one was already in the queue #2377

@rollsicecream rollsicecream deleted the convert-html-messengers branch January 31, 2024 12:54
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-20/16594/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants