-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update!: Add Cromite to Mobile Browsers #2381
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Discussion thread for this https://discuss.privacyguides.net/t/cromite-bromite-fork/13274 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must receive engine updates in 0-1 days from upstream release.
0-1 days is a bit too strict for a one-person project. DivestOS claims it's "within a week," my personal observation is usually 1 day, occasionally up to 3. Maybe we can ask the maintainer for this
we also have to change the criteria at the bottom of this page if we add a recommendation which doesn't match them.
or should we ask the dev about their release schedule? since referring to the chromium release blog is not the best idea since not every version is an exact match |
This pull request has been mentioned on Privacy Guides. There might be relevant details there: https://discuss.privacyguides.net/t/cromite-bromite-fork/13274/47 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Seems like it doesn't uses HTML admonitions that should now be used on the website. Of course, there's no rush for this but we will need to convert this page later on to the new admonitions.
Also, speaking of this PR, seems like the "homepage button" for Cromite isn't here! There's cromite.org available but it redirects to the GitHub page. So, what we could do here is : Display the "homepage" button that contains cromite.org or the GH page. Something like this should be added :
[:octicons-home-16: Homepage](https://cromite.org){ .md-button .md-button--primary }
Sorry to intrude. but, if it is possible, i would ask you to be patient with your publication, until issue uazo/cromite#710 is resolved. thank you for your consideration. another thing, and please excuse me, I don't think those recommendations are good as default for cromite, but I don't want to sound cheeky and I might be wrong after all. |
thanks for your patience, i'll let you know that i've solved at least for windows and android. linux is a bit more complex and for now it's a todo. |
if you want I can tell you what I think the defaults should be, actually I plan to include them when I try to put cromite on the google store, which I will only do after I have written the privacy policy (which are not easy to write because, it is true, unlike other browsers, I do not send myself any data, ever, but the browser collects a lot locally). |
the recommendations were copied from the ones used for Bromite which appears to be written some time (2+ years) ago personally i don't really agree with them either but eh |
c822236
to
7b2841c
Compare
This pull request has been mentioned on Privacy Guides. There might be relevant details there: https://discuss.privacyguides.net/t/suggest-projects-that-are-still-in-development-phase/20443/8 |
Since the criteria is now just "Must receive engine updates from upstream releases quickly." it should now qualify. We still should discuss whether "always on incognito" is necessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for all your work with this PR!
Signed-off-by: Jonah Aragon <jonah@triplebit.net> Co-Authored-By: redoomed1 <161974310+redoomed1@users.noreply.github.com>
This pull request has been mentioned on Privacy Guides Community. There might be relevant details there: |
Changes proposed in this PR:
Criteria:
yes
0-1 days is a bit too strict for a one-person project. DivestOS claims it's "within a week," my personal observation is usually 1 day, occasionally up to 3. Maybe we can ask the maintainer for this
doesn't appear to
yes