Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update!: Add Cromite to Mobile Browsers #2381

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

austinhuang0131
Copy link
Contributor

@austinhuang0131 austinhuang0131 commented Jan 30, 2024

Changes proposed in this PR:

  • add Cromite back. Logo (svg) is my own reproduction of the official logo (which is in png).
  • I have disclosed any relevant conflicts of interest in my post. (none other than being a user of it)
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work. (Some are referenced from b3ceb64 but it's y'all so I don't think there is a copyright issue)
  • I agree to the Community Code of Conduct.

Criteria:

Must support automatic updates.

yes

Must receive engine updates in 0-1 days from upstream release.

0-1 days is a bit too strict for a one-person project. DivestOS claims it's "within a week," my personal observation is usually 1 day, occasionally up to 3. Maybe we can ask the maintainer for this

Any changes required to make the browser more privacy-respecting should not negatively impact user experience.

doesn't appear to

Android browsers must use the Chromium engine.

yes

This comment was marked as outdated.

@dngray
Copy link
Member

dngray commented Jan 30, 2024

Discussion thread for this https://discuss.privacyguides.net/t/cromite-bromite-fork/13274

@freddy-m freddy-m added the c:browsers browsers, add-ons, and related topics label Jan 30, 2024
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must receive engine updates in 0-1 days from upstream release.

0-1 days is a bit too strict for a one-person project. DivestOS claims it's "within a week," my personal observation is usually 1 day, occasionally up to 3. Maybe we can ask the maintainer for this

we also have to change the criteria at the bottom of this page if we add a recommendation which doesn't match them.

@austinhuang0131
Copy link
Contributor Author

or should we ask the dev about their release schedule? since referring to the chromium release blog is not the best idea since not every version is an exact match

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/cromite-bromite-fork/13274/47

Copy link
Contributor

@rollsicecream rollsicecream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Seems like it doesn't uses HTML admonitions that should now be used on the website. Of course, there's no rush for this but we will need to convert this page later on to the new admonitions.

Also, speaking of this PR, seems like the "homepage button" for Cromite isn't here! There's cromite.org available but it redirects to the GitHub page. So, what we could do here is : Display the "homepage" button that contains cromite.org or the GH page. Something like this should be added :

[:octicons-home-16: Homepage](https://cromite.org){ .md-button .md-button--primary }

@uazo
Copy link

uazo commented Feb 8, 2024

Sorry to intrude.
first of all, thank you for taking cromite into consideration, that pleases me.

but, if it is possible, i would ask you to be patient with your publication, until issue uazo/cromite#710 is resolved.
to date I have some doubts about the legality of the distribution of my executables, regarding the support of aac and h264, due to the lack of a licence that it will not be possible for me to purchase it due to the high costs
Although I am not aware of how many installations my browser has, under 100,000 I can be comfortable, but a higher spread that might happen after your change. could bring me legal problems.

thank you for your consideration.
I remain at your disposal if you have any questions.

another thing, and please excuse me, I don't think those recommendations are good as default for cromite, but I don't want to sound cheeky and I might be wrong after all.

@uazo
Copy link

uazo commented Mar 12, 2024

until issue uazo/cromite#710 is resolved.

thanks for your patience, i'll let you know that i've solved at least for windows and android. linux is a bit more complex and for now it's a todo.

@uazo
Copy link

uazo commented Mar 12, 2024

if you want I can tell you what I think the defaults should be, actually I plan to include them when I try to put cromite on the google store, which I will only do after I have written the privacy policy (which are not easy to write because, it is true, unlike other browsers, I do not send myself any data, ever, but the browser collects a lot locally).

@austinhuang0131
Copy link
Contributor Author

the recommendations were copied from the ones used for Bromite which appears to be written some time (2+ years) ago

personally i don't really agree with them either but eh

@I-I-IT I-I-IT mentioned this pull request Jun 7, 2024
4 tasks
@jonaharagon jonaharagon changed the title Add Cromite to Mobile Browsers update: Add Cromite to Mobile Browsers Aug 1, 2024
@jonaharagon jonaharagon changed the title update: Add Cromite to Mobile Browsers update!: Add Cromite to Mobile Browsers Aug 1, 2024
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/suggest-projects-that-are-still-in-development-phase/20443/8

@austinhuang0131
Copy link
Contributor Author

austinhuang0131 commented Nov 9, 2024

Since the criteria is now just "Must receive engine updates from upstream releases quickly." it should now qualify. We still should discuss whether "always on incognito" is necessary

jonaharagon pushed a commit to austinhuang0131/privacyguides.org that referenced this pull request Nov 12, 2024
docs/tools.md Outdated Show resolved Hide resolved
docs/tools.md Outdated Show resolved Hide resolved
docs/mobile-browsers.md Outdated Show resolved Hide resolved
docs/mobile-browsers.md Outdated Show resolved Hide resolved
docs/mobile-browsers.md Outdated Show resolved Hide resolved
docs/mobile-browsers.md Outdated Show resolved Hide resolved
docs/mobile-browsers.md Outdated Show resolved Hide resolved
docs/mobile-browsers.md Outdated Show resolved Hide resolved
redoomed1 pushed a commit to austinhuang0131/privacyguides.org that referenced this pull request Nov 12, 2024
docs/mobile-browsers.md Outdated Show resolved Hide resolved
docs/mobile-browsers.md Outdated Show resolved Hide resolved
docs/mobile-browsers.md Outdated Show resolved Hide resolved
docs/mobile-browsers.md Outdated Show resolved Hide resolved
docs/mobile-browsers.md Outdated Show resolved Hide resolved
docs/mobile-browsers.md Show resolved Hide resolved
docs/mobile-browsers.md Outdated Show resolved Hide resolved
Copy link
Member

@redoomed1 redoomed1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for all your work with this PR!

docs/mobile-browsers.md Outdated Show resolved Hide resolved
redoomed1 pushed a commit to austinhuang0131/privacyguides.org that referenced this pull request Nov 14, 2024
Signed-off-by: Jonah Aragon <jonah@triplebit.net>
Co-Authored-By: redoomed1 <161974310+redoomed1@users.noreply.github.com>
@jonaharagon jonaharagon merged commit fa64257 into privacyguides:main Nov 14, 2024
5 checks passed
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides Community. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-11-14/22431/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:browsers browsers, add-ons, and related topics
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants