Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update styling to fix margins on mobile #2341

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Update styling to fix margins on mobile #2341

merged 1 commit into from
Dec 2, 2023

Conversation

r-j-taylor
Copy link
Contributor

@r-j-taylor r-j-taylor commented Nov 27, 2023 •
edited
Loading

Changes proposed in this PR:

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@r-j-taylor r-j-taylor marked this pull request as ready for review November 27, 2023 19:30
@netlify Netlify
Copy link

netlify bot commented Nov 27, 2023 •
edited
Loading

✅ Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit dc054d9
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/656ad391fefb890008d3508c
😎 Deploy Preview https://deploy-preview-2341.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 4 paths audited
Performance: 70 (🔴 down 4 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 88 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@r-j-taylor r-j-taylor changed the title Update home.en.html to properly extend main.html Update home page styling to have proper margins on mobile Nov 27, 2023
@r-j-taylor
Copy link
Contributor Author

Apologies for pushing some commits after marking the PR as ready for review; I was trying to get it to generate the preview. It's actually ready now!

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/homepage-has-no-margins-on-mobile/14554/9

@dngray dngray changed the title Update home page styling to have proper margins on mobile Update styling to fix margins on mobile Dec 2, 2023
@r-j-taylor @dngray
Update styling to fix margins on mobile (privacyguides#2341)
dc054d9 
Signed-off-by: Jonah Aragon <jonah@triplebit.net>
Signed-off-by: Daniel Gray <dng@disroot.org>
@dngray dngray merged commit dc054d9 into privacyguides:main Dec 2, 2023
3 checks passed
@dngray dngray added the t:correction content corrections or errors label Dec 2, 2023
@r-j-taylor r-j-taylor deleted the patch-1 branch December 6, 2023 05:20
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-19/16257/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaharagon jonaharagon jonaharagon approved these changes

@dngray dngray dngray approved these changes

Assignees
No one assigned
Labels
t:correction content corrections or errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r-j-taylor @privacyguides-bot @jonaharagon @dngray