Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Safari settings for iOS 17 #2338

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Update Safari settings for iOS 17 #2338

merged 1 commit into from
Feb 10, 2024

Conversation

friadev
Copy link
Contributor

@friadev friadev commented Nov 20, 2023

Changes proposed in this PR:

  • Updated the settings for Safari to reflect changes in iOS 17
  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@netlify Netlify
Copy link

netlify bot commented Nov 20, 2023 •
edited
Loading

✅ Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 8a25c48
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/65c790863f94400008c34ff8
😎 Deploy Preview https://deploy-preview-2338.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 4 paths audited
Performance: 77 (🟢 up 2 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 88 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@freddy-m freddy-m added the c:os operating systems and related topics label Nov 23, 2023
jonaharagon
jonaharagon requested changes Dec 2, 2023
View reviewed changes
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Headers here should correspond w/ headers on the settings page, I think these suggestions all match.

docs/mobile-browsers.md Outdated Show resolved Hide resolved
docs/mobile-browsers.md Outdated Show resolved Hide resolved
@friadev @jonaharagon @dngray
Update Safari settings for iOS 17 (#2338)
8a25c48 
Co-authored-by: Jonah Aragon <jonah@triplebit.net>
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray added the t:correction content corrections or errors label Feb 10, 2024
@dngray dngray merged commit 8a25c48 into privacyguides:main Feb 10, 2024
4 checks passed
@friadev friadev deleted the pr-safari branch February 11, 2024 09:32
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-20-1/16742/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaharagon jonaharagon jonaharagon approved these changes

@dngray dngray dngray approved these changes

@freddy-m freddy-m Awaiting requested review from freddy-m

Assignees
No one assigned
Labels
c:os operating systems and related topics t:correction content corrections or errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@friadev @privacyguides-bot @jonaharagon @dngray @freddy-m