Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing commas before and missing dots after 'etc' #2125

Merged
merged 8 commits into from
Apr 12, 2023
Merged

Fix missing commas before and missing dots after 'etc' #2125

merged 8 commits into from
Apr 12, 2023

Conversation

ticklemyIP
Copy link
Contributor

@ticklemyIP ticklemyIP commented Apr 11, 2023

Changes proposed in this PR:

I have noticed two commas that were missing before ' etc.' strings in enumerations or listings, and are not otherwise. I have fixed those after grepping the source. I have also fixed dots that are sometimes missing after 'etc'.

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

Signed-off-by: ticklemyIP <126688461+ticklemyIP@users.noreply.github.com>
Signed-off-by: ticklemyIP <126688461+ticklemyIP@users.noreply.github.com>
@ticklemyIP ticklemyIP requested a review from jonaharagon as a code owner April 11, 2023 20:47
@ticklemyIP
Copy link
Contributor Author

ticklemyIP commented Apr 11, 2023

I have also noticed inconsistencies with the brackets. Sometimes it's ', etc)', sometimes ', etc.)' if this is decided I can patch those as well and add them to this merge request. I assume it's the latter because, its an abbreviation.
For example:

207:Proton VPN, in addition to accepting credit/debit cards, PayPal, and [Bitcoin](advanced/payments.md#other-coins-bitcoin-ethereum-etc), also accepts **cash/local currency** as an anonymous form of payment.
253:- Killswitch with highly configurable options (enable/disable on certain networks, on boot, etc.)
270:- No personal information accepted (autogenerated username, no email required, etc.).
313:    - Reusing personal information (e.g., email accounts, unique pseudonyms, etc) that they accessed without anonymity software (Tor, VPN, etc.)
327:While not strictly requirements, there are some factors we looked into when determining which providers to recommend. These include adblocking/tracker-blocking functionality, warrant canaries, multihop connections, excellent customer support, the number of allowed simultaneous connections, etc.

router.md
6:Below are a few alternative operating systems, that can be used on routers, Wi-Fi access points, etc.

os/linux-overview.md
109:Some distributions (particularly those aimed at advanced users) are more barebones and expect you to do things yourself (e.g. Arch or Debian). These will require running the "package manager" (`apt`, `pacman`, `dnf`, etc.) manually in order to receive important security updates.
117:Many desktop Linux distributions (Fedora, openSUSE, etc) will come with [NetworkManager](https://en.wikipedia.org/wiki/NetworkManager), to configure Ethernet and Wi-Fi settings.
139:This [option](https://dnf.readthedocs.io/en/latest/conf_ref.html#options-for-both-main-and-repo) is currently off by default. We recommend adding `countme=false` to `/etc/dnf/dnf.conf` just in case it is enabled in the future. On systems that use `rpm-ostree` such as Silverblue, the countme option is disabled by masking the [rpm-ostree-countme](https://fedoramagazine.org/getting-better-at-counting-rpm-ostree-based-systems/) timer.

mobile-browsers.md
119:[Brave Sync](https://support.brave.com/hc/en-us/articles/360059793111-Understanding-Brave-Sync) allows your browsing data (history, bookmarks, etc.) to be accessible on all your devices without requiring an account and protects it with E2EE.

email.md
70:Proton Mail [accepts](https://proton.me/support/payment-options) cash by mail in addition to standard credit/debit card, [Bitcoin](advanced/payments.md#other-coins-bitcoin-ethereum-etc), and PayPal payments.
185:StartMail accepts Visa, MasterCard, American Express and Paypal. StartMail also has other [payment options](https://support.startmail.com/hc/en-us/articles/360006620637-Payment-methods) such as [Bitcoin](advanced/payments.md#other-coins-bitcoin-ethereum-etc) (currently only for Personal accounts) and SEPA Direct Debit for accounts older than a year.
413:- Encrypts all account data (Contacts, Calendars, etc) at rest with zero-access encryption.
436:- Accepts [anonymous payment options](advanced/payments.md) ([cryptocurrency](cryptocurrency.md), cash, gift cards, etc.)
489:- Must self-host analytics (no Google Analytics, Adobe Analytics, etc). The provider's site must also comply with [DNT (Do Not Track)](https://en.wikipedia.org/wiki/Do_Not_Track) for those who wish to opt-out.
496:- Reusing personal information e.g. (email accounts, unique pseudonyms, etc) that they accessed without anonymity software (Tor, VPN, etc)
501:- Clear and easy to read documentation. This includes things like, setting up 2FA, email clients, OpenPGP, etc.

desktop.md
165:The Qubes OS operating system secures the computer by isolating subsystems (e.g., networking, USB, etc.) and applications in separate VMs. Should one part of the system be compromised, the extra isolation is likely to protect the rest of the system. For further details see the Qubes [FAQ](https://www.qubes-os.org/faq/).```

@netlify
Copy link

netlify bot commented Apr 11, 2023

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 618bf2e
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/6435d94e9676440008334357
😎 Deploy Preview https://deploy-preview-2125--privacyguides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jonaharagon
Copy link
Member

jonaharagon commented Apr 11, 2023

Yes they should all have a period at the end.

..., etc.
..., etc., ...
... etc
..., etc
..., etc, ...

Signed-off-by: ticklemyIP <126688461+ticklemyIP@users.noreply.github.com>
Signed-off-by: ticklemyIP <126688461+ticklemyIP@users.noreply.github.com>
Signed-off-by: ticklemyIP <126688461+ticklemyIP@users.noreply.github.com>
Signed-off-by: ticklemyIP <126688461+ticklemyIP@users.noreply.github.com>
Signed-off-by: ticklemyIP <126688461+ticklemyIP@users.noreply.github.com>
Signed-off-by: ticklemyIP <126688461+ticklemyIP@users.noreply.github.com>
@ticklemyIP ticklemyIP changed the title Fix missing commas before ' etc.' Fix missing commas before and missing dots after 'etc' Apr 11, 2023
@ticklemyIP
Copy link
Contributor Author

Okay I seem to have found all of the missing dots and fixed them.

@blacklight447 blacklight447 merged commit 8c438b8 into privacyguides:main Apr 12, 2023
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-9/12311/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants