Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mention of Libredirect #1977

Closed
wants to merge 1 commit into from
Closed

Add mention of Libredirect #1977

wants to merge 1 commit into from

Conversation

dngray
Copy link
Member

@dngray dngray commented Feb 14, 2023

No description provided.

@dngray dngray marked this pull request as draft February 14, 2023 16:54
@netlify
Copy link

netlify bot commented Feb 14, 2023

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 7aba35e
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/63edb21658f34d0008f813a8
😎 Deploy Preview https://deploy-preview-1977--privacyguides.netlify.app/frontends
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@matchboxbananasynergy
Copy link
Contributor

Is the functionality that this provides worth recommending another extension?

@dngray
Copy link
Member Author

dngray commented Feb 14, 2023

Is the functionality that this provides worth recommending another extension?

If you want your browser to redirect to these things, then this is probably the most maintained, customizable thing out there. As far as fingerprinting goes, no concern because it only redirects to the instances you want.

@dngray dngray added the c:software self-hosted/decentralized software and related topics label Feb 15, 2023
dngray added a commit that referenced this pull request Feb 16, 2023
@dngray dngray marked this pull request as ready for review February 16, 2023 04:23
dngray added a commit that referenced this pull request Feb 16, 2023
dngray added a commit that referenced this pull request Feb 16, 2023
ghost
ghost previously approved these changes Feb 16, 2023
@blacklight447
Copy link
Member

Doesn this mean you have to trust the maker of the extension to not redirect you in cases you don't want?

I mean it could redirect you to a fake bank site even if you fill in the right url right?

@ghost
Copy link

ghost commented Feb 16, 2023

Doesn this mean you have to trust the maker of the extension to not redirect you in cases you don't want?

I mean it could redirect you to a fake bank site even if you fill in the right url right?

Pretty much yeah.

@ghost ghost dismissed their stale review February 19, 2023 03:44

Security concerns

@dngray
Copy link
Member Author

dngray commented Feb 20, 2023

Security concerns

I'm wondering if we should reformat that page to have one warning at the top, because it applies to all frontends

When self-hosting, it is important that you have other people using your instance as well in order for you to blend in. You should be careful with where and how you are hosting ProxiTok, as other peoples' usage will be linked to your hosting.

For example is repeated throughout as is:

When you are using a ProxiTok instance, make sure to read the privacy policy of that specific instance. ProxiTok instances can be modified by their owners and therefore may not reflect their associated privacy policy. Some instances have Tor .onion addresses which may grant some privacy as long as your search queries don't contain PII.

Though this would require some restructuring, for example web based frontends and local apps

@blacklight447
Copy link
Member

I am personally not really convinced that the added convience is worth the security risk here, can't folks better not just use bookmarks?

@dngray
Copy link
Member Author

dngray commented Feb 20, 2023

Doesn this mean you have to trust the maker of the extension to not redirect you in cases you don't want?

I do think the risk, is minimal, and it would be very obvious if they did.

There are security benefits from frontends when you're not using JavaScript or you are using .onion services, which Libredirect can optionally select.

The ability to do something harmful without JavaScript is pretty limited. I still think it should be mentioned with a warning.

@matchboxbananasynergy
Copy link
Contributor

matchboxbananasynergy commented Feb 20, 2023

If the extension was compromised (happens), couldn't it change the redirects to something malicious? If so, I don't think the little convenience this provides is worth the potential risk, and we shouldn't be teaching Privacy Guides' readers that such extensions are okay, in my opinion.

Also, is the default for it to redirect to a random instance? If so, that introduces a whole heck of a lot more trusted parties. What if an instance is compromised, and people are redirected to it?

It's really not that hard to open a video (for example) in your frontend of choice. All you have to do is paste the entire YouTube (again, for example) into your frontend of choice, and it'll take you to that video. I for sure know that this works with Piped and FreeTube.

Suggesting this feels like a regression. People should be making educated choices about which instances they choose to trust. And while I'm sure that Libredirect allows you to pin specific instances, that should be the default (it might be, not sure), and even then, the potential issues that this can cause just don't make the juice worth the squeeze imo.

@dngray
Copy link
Member Author

dngray commented Feb 20, 2023

Also, is the default for it to redirect to a random instance? If so, that introduces a whole heck of a lot more trusted party. What if an instance is compromised, and people are redirected to it?

That is the thing I'm concerned about the most.

Suggesting this feels like a regression. People should be making educated choices about which instances they choose to trust. And while I'm sure that Libredirect allows you to pin specific instances, that should be the default (it might be, not sure), and even then, the potential issues that this can cause just don't make the juice worth the squeeze imo.

Which is a fair point, it's not the default.

@dngray dngray closed this Feb 20, 2023
@jonaharagon
Copy link
Member

I was going to reopen this because I think you are wrong @matchboxbananasynergy, the default is to not redirect anything at all, so enabling a redirect requires manual config intervention, and if you enable a redirect it defaults to a single pre-set server and not a random selection out of all the available options. (And switching instances is on the same page you're already on to enable the redirect anyways, so I don't have any UX concerns there with people accidentally choosing an instance they're not familiar with).

However, I then saw it requires manual installation in developer mode on Chromium browsers, which I'm not comfortable with recommending :)

If they move to Manifest v3 and publish to the Chrome Web Store in the future though, I do want to reopen this discussion at that time.

@jonaharagon jonaharagon deleted the pr-libredirect branch February 24, 2023 20:18
@dngray dngray restored the pr-libredirect branch March 1, 2023 02:31
@dngray
Copy link
Member Author

dngray commented Mar 1, 2023

I was going to reopen this because I think you are wrong @matchboxbananasynergy, the default is to not redirect anything at all, so enabling a redirect requires manual config intervention, and if you enable a redirect it defaults to a single pre-set server and not a random selection out of all the available options

Oh, that's not so bad. I couldn't remember if I had set that or not.

If they move to Manifest v3 and publish to the Chrome Web Store in the future though, I do want to reopen this discussion at that time.

We'll revisit it then. I've restored the branch, so we can look at it then.

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides Community. There might be relevant details there:

https://discuss.privacyguides.net/t/libredirect-extension-should-we-use-it-or-not/21983/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:software self-hosted/decentralized software and related topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants