Support gabi with updated keyshare protocol #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version of gabi produces a proofU that contains both keyshares. This commit changes the following:
- irmaclient.Client.startKeyshareSession() is now called newKeyshareSession, because it does not actually immediately start the session. Instead, it returns after checking the user's PIN. This is necessary because what happens next now differs per session type, see next point.
- In case of disclosure/ABS, the session proceeds as before. In case of issuance, /api/v2/prove/getPs at the keyshare server is first invoked to retrieve the P values (R_0^{keyshare server secret}), after which the session is started.
- In case of the old keyshare protocol, the keyshare's P is divided out from the U of the proofU because that is what the issuer expects in the old keyshare protocol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of
gabiproduces aproofUthat proves knowledge of both keyshares. To take that into account, this commit changes the following:irmaclient.Client.startKeyshareSession()is now callednewKeyshareSession, because it does not actually immediately start the session. Instead, it returns after checking the user's PIN. This is necessary because what happens next now differs per session type, see next point./api/v2/prove/getPsat the keyshare server is first invoked to retrieve thePvalues (R_0^{keyshare server secret}), after which the session is started.Pis divided out from theUof theproofUbecause that is what the issuer expects in the old keyshare protocol.Note: this commit uses the new function in
gabiadded by privacybydesign/gabi#38. Once that is merged,gabishould be bumped ingo.mod.