This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
fix to check account empty for existence in BALANCE bus mapping
#1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
han0110
approved these changes
Dec 28, 2022
DreamWuGit
approved these changes
Dec 28, 2022
rrzhang139
pushed a commit
to rrzhang139/zkevm-circuits
that referenced
this pull request
Dec 29, 2022
…ivacy-scaling-explorations#1007) * Fix to check account empty for existence in `BALANCE` bus-mapping. * Add a test case for empty account.
ChihChengLiang
added a commit
that referenced
this pull request
Dec 29, 2022
* deuduplicated a few functions * deduplicated parse_calldata and parse_code * fixed clippy errors * fix log copyrwc when is_persistent false (#1015) * fix to check account empty for existence in `BALANCE` bus mapping (#1007) * Fix to check account empty for existence in `BALANCE` bus-mapping. * Add a test case for empty account. Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com> Co-authored-by: DreamWuGit <wwuwwei@126.com> Co-authored-by: Steven <asongala@163.com>
noel2004
pushed a commit
to noel2004/zkevm-circuits
that referenced
this pull request
Nov 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1006
As @han0110 mentioned in #973 (comment), we should replace checking account existing in state DB with account
is_emptyinBALANCEbus-mapping.Also referenced eip-158.