migrate-diff: error on non-existing sqlite database #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default behaviour of the sqlite driver is to implicitly create the database when we connect to it. Given that - db push has a database creation step - implicit database creation is otherwise unexpected - there is a stub of this for some commands in the TS code already - we have more than enough time to QA changes we make today This commit changes the sql migration connector so that whenever we connect to a sqlite database, we return a P1003 (DatabaseDoesNotExist) error if there is no file at the expected path. closes prisma/prisma#12226
4de1e02 to
e95e159
Compare
pimeys
approved these changes
Apr 11, 2022
tomhoule
added a commit
to prisma/prisma
that referenced
this pull request
Apr 11, 2022
See prisma/prisma-engines#2836 for the details on the engines side of things. The consequence of that PR is that we are now doing that check in engines, and doing it in more cases than the check removed in this PR.
Jolg42
added a commit
to prisma/prisma
that referenced
this pull request
Apr 12, 2022
tomhoule
added a commit
to prisma/prisma
that referenced
this pull request
Apr 22, 2022
See prisma/prisma-engines#2836 for the details on the engines side of things. The consequence of that PR is that we are now doing that check in engines, and doing it in more cases than the check removed in this PR.
Jolg42
pushed a commit
to prisma/prisma
that referenced
this pull request
Apr 25, 2022
* chore(migrate): remove sqlite check now performed engine-side See prisma/prisma-engines#2836 for the details on the engines side of things. The consequence of that PR is that we are now doing that check in engines, and doing it in more cases than the check removed in this PR. * . * chore(migrate): remove sqlite check now performed engine-side See prisma/prisma-engines#2836 for the details on the engines side of things. The consequence of that PR is that we are now doing that check in engines, and doing it in more cases than the check removed in this PR. * . * cli: updated snapshot in doctor * sdk: updated snapshots * migrate: updated snapshots Co-authored-by: Alberto Schiabel <skiabo97@gmail.com> Co-authored-by: Alberto Schiabel <jkomyno@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behaviour of the sqlite driver is to implicitly create the
database when we connect to it.
Given that
This commit changes the sql migration connector so that whenever we
connect to a sqlite database, we return a P1003 (DatabaseDoesNotExist)
error if there is no file at the expected path.
closes prisma/prisma#12226