Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Lambda landing page #5293

Merged
merged 21 commits into from
Sep 26, 2023
Merged

AWS Lambda landing page #5293

merged 21 commits into from
Sep 26, 2023

Conversation

jharrell
Copy link
Member

@jharrell jharrell commented Sep 8, 2023

Fixes #5157

Describe this PR

This makes our AWS Lambda page more general. Originally the goal was to have separate pages per framework (we started with Serverless Framework) but we quickly realized that we have "generic" tips for AWS Lambda and then framework-specific tips. I thought of the following three choices:

  1. A mega page with both generic tips and framework-specific tips
  2. A page for generic tips and then subpages for framework-specific tips
  3. Pages for framework-specific tips with a "generic" section at top of each.

I chose 1 as it did not repeat content (which could become out of sync) and made it so that all steps a user should follow are on the same page.

@jharrell jharrell self-assigned this Sep 8, 2023
@vercel
Copy link

vercel bot commented Sep 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 5:15pm

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

This PR changes the following pages (Vercel Preview Deploy links):

Changed Vercel links

(Note that links will only be valid after Vercel preview deploy succeeded)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

This PR probably requires the following redirects to be added to vercel.json:

  • This PR does not change any pages in a way that would require a redirect.

Co-authored-by: Alex Ruheni <33921841+ruheni@users.noreply.github.com>
jharrell and others added 2 commits September 19, 2023 15:25
…-aws-lambda.mdx

Co-authored-by: Alex Ruheni <33921841+ruheni@users.noreply.github.com>
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great and is so much better than what we have! I've left a small suggestion but I'd say let's merge it and then possibly refine further in the future 🙏

Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually went ahead and commited my suggestion myself 😄 so this is ready to merge from my end!

@jharrell jharrell merged commit 851dcc9 into main Sep 26, 2023
@jharrell jharrell deleted the jharrell/issue5157 branch September 26, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make an AWS Lambda landing page
4 participants