-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Nussknacker version to 1.0.0 (refactor to component provider) #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avan1235
force-pushed
the
avan1235/refactor-component-provider
branch
from
June 3, 2021 19:33
e072327
to
a44778b
Compare
We wait for official release of Nussknacker 0.3.1 with this PR to be merged so it's changed to draft |
avan1235
force-pushed
the
avan1235/refactor-component-provider
branch
5 times, most recently
from
October 20, 2021 10:15
58f5ea9
to
28d8b83
Compare
Define explicit minio image version
avan1235
force-pushed
the
avan1235/refactor-component-provider
branch
from
October 20, 2021 10:34
28d8b83
to
a3796b2
Compare
avan1235
changed the title
Refactor to component provider
Update Nuccknacker version to 1.0.0 (refactor to component provider)
Oct 20, 2021
jkukowski
changed the title
Update Nuccknacker version to 1.0.0 (refactor to component provider)
Update Nussknacker version to 1.0.0 (refactor to component provider)
Oct 20, 2021
jkukowski
approved these changes
Oct 20, 2021
prinz/src/main/scala/pl/touk/nussknacker/prinz/engine/PrinzComponentProvider.scala
Outdated
Show resolved
Hide resolved
prinz/src/main/scala/pl/touk/nussknacker/prinz/model/ModelSignature.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #169. Include upgrade to nussknacker 1.0.0 in samples. I will publish the packages of jar files that will depend on new nussknacker model and make them as a new major version, as they would not be compatible with old nussknacker model.
Changes to docker environment is based on the repository scheme from https://github.com/TouK/nussknacker-quickstart
I would suggest starting to keep the same version names as nussknacker has anyway to make it more readable