Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix infinite loop in getRangeGlyphClass #24

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

LabhanshAgrawal
Copy link
Contributor

Fixes #23

Just adding search++; similar to

However, I think both the places should also have something like

start = search;
currentClass = clazz;

Can add that too if you think it sounds correct.

@boldandbrad
Copy link

Can this please be merged?

Copy link
Collaborator

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LabhanshAgrawal looks good, wasn't watching this repo

@Tyriar Tyriar merged commit b6ee748 into princjef:master Jan 6, 2022
@Tyriar
Copy link
Collaborator

Tyriar commented Jan 6, 2022

Can add that too if you think it sounds correct.

Would like to minimize the changes as much as possible as I'm not familiar with the code, if you could come up with a test case that covers this that would be a nice addition.

@LabhanshAgrawal LabhanshAgrawal deleted the loops branch January 6, 2022 17:38
@LabhanshAgrawal
Copy link
Contributor Author

Can add that too if you think it sounds correct.

Would like to minimize the changes as much as possible as I'm not familiar with the code, if you could come up with a test case that covers this that would be a nice addition.

I'll have to go through the full code to be 100% sure, but based on how this type of code is written generally, that's what I got at. Will check it out, didn't know you could merge pr's here, that's great.

@princjef
Copy link
Owner

princjef commented Jan 7, 2022

🎉 This PR is included in version 1.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop on Fira Code 6.*
4 participants