Restrict menu heading slot tags #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/view-components/AEL7k8DfTuCnoEhDv3dmMXmxemhJ |
5087cde to
933223c
Compare
2a14f36 to
7a03f48
Compare
joelhawksley
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #644
What
This PR updates the heading slot of the
MenuComponentto require thetag:argument to be passed in. The tag must be one of the heading tags.Why
This menu heading looks like a heading and functions as a heading so we should be using a heading tag rather than a
:div. This will allow assistive technology users to navigate to the heading more quickly.Notes
As a reference, a similar vertical menu menu heading on this w3 headings page is rendered with a heading tag.
Part of #491