Restrict allowed tags for AvatarStack
#510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/view-components/39br5ZCp2246J9jL5XsDDFjN3qyB |
koddsson
approved these changes
Apr 30, 2021
joelhawksley
approved these changes
Apr 30, 2021
CHANGELOG.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## main | |||
|
|
|||
| * **Breaking change:** Explicitly limit tag for `AvatarStack` | |||
There was a problem hiding this comment.
Suggested change
| * **Breaking change:** Explicitly limit tag for `AvatarStack` | |
| * **Breaking change:** Explicitly limit tag for `AvatarStack` to `:div` and `:span`. |
d6e963c to
bf23b4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
AvatarStackto:divand:span. I grepped dotcom forAvatarStackComponentinitialized withtag:and did not find any. I did see a usage of non-primerAvatarStackon a<span>. Based off this,:divand:spanas allowed tags and keeping the current:divseems reasonable.Why
Currently
AvatarStackaccepts any tags which we probably don't want.Notes
Part of #491
The regex I used to grep for all instances of this component initialized with
tag(accounting for multiline initializations) is:I am not great at regex so if you have tips/tricks/other patterns for grepping for these kinds of things, let me know!